Environment::nodeId Should Throw SystemException When Node ID is 0

[aleks-f]

Discussed in #4326

^{Originally posted by andrewauclair December 7, 2023}
We've had a few issues with this recently. If the Environment_UNIX.cpp EnvironmentImpl::nodeIdImpl fails to find a node ID it simply leaves the node ID as all 0's. A similar thing appears to happen on Windows. We then assume that this is a valid ID and use it. Some parts of our system end up getting 0's and other parts get a valid node ID and fail to communicate.

I think that this would work better if a SystemException was thrown when nodeIdImpl fails to set a value.

[aleks-f]

I think that this would work better if a SystemException was thrown when nodeIdImpl fails to set a value.

The documentation says if it can't find an ethernet adapter, but it should throw if it can not produce nodeId for any reason.

@andrewauclair please create a PR, and @matejk and myself will review

[andrewauclair]

Sounds good. One of my coworkers just happened to run into the Windows issue I mentioned. It looks like our Dell laptops only have wifi adapters and no ethernet adapters. The win32 nodeIdImpl only looks for ethernet adapters. Not sure what a good solution would be for this. Going to give it some thought.

[obiltschnig]

EnvironmentImpl::nodeIdImpl() should be changed to also look for WiFi adapters if no Ethernet adapter was found.
And throw only if neither an Ethernet nor a WiFi adapter could be found.