Reorganise source code of external libraries (pre-requisite for #4354) #4358
Comments
|
I'd name the directory |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
{{ message }}
From #4354 by @teksturi :
Separate external source files to own folder
It would be quite hard to exclude every external source without moving them to different folder. This same thing will happened also with other static analyzer tools, formatting tools, compiler options. So if we move them separated folders we can always exclude them more easily.
We can consider couple options here (example for zlib). Note that "external" can also be replaced with some other word if wanted.
My personal vote goes to 2, 4 or 7. Probably 7 because that way it so easy to seperete everything to one place. We can have example update script which checks all new version for those.
Still need to think what about external files which are also in include/ there we would probably need external folder. Example of this kind of file is "Foundation/include/Poco/ordered_map.h"
Maybe something like this for external files.
I still need to prototype a little bit. We probably still do not want to build these as libs as before. Also we probably want to have nice include paths
#include "Poco/external/pdjson/pdjson.h"
We could also do some magic that we can always do that even when POCO_UNBUNDLED is used. But that is not very high priority but would be nice.
Structure reorganization is needed if we want to have clang-tidy automated in good way. Else we will clatter with exclude rules. That would be same work as moving files to different location. Moving them will also help in other stuff like taking clang-format in use.
Easiest reorganization would be this
This way almost nothing change but we can exclude those pretty easily.
The text was updated successfully, but these errors were encountered: