Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.5.1 build fails on OS X when using libc++ #46

Closed
lucas-clemente opened this issue Dec 30, 2012 · 1 comment
Closed

1.5.1 build fails on OS X when using libc++ #46

lucas-clemente opened this issue Dec 30, 2012 · 1 comment
Assignees
Milestone

Comments

@lucas-clemente
Copy link
Contributor

Compiling the 1.5.1 prerelease using libc++ fails in the file DirectoryWatcher.cpp.

src/DirectoryWatcher.cpp:419:4: error: use of undeclared identifier 'close'
                        close(_dirFD);
                        ^
src/DirectoryWatcher.cpp:426:3: error: use of undeclared identifier 'close'
                close(_dirFD);
                ^
src/DirectoryWatcher.cpp:427:3: error: use of undeclared identifier 'close'
                close(_queueFD);
                ^

My configure command was

../src/configure --prefix=../install --no-tests --no-samples --cflags='-fPIC -stdlib=libc++' --static --omit=Data,Zip --config=Darwin64-clang

As a fix, #include <unistd.h> should be inserted in the file on OS X. I have not submitted a pull request since I'm not 100% sure where in the file to put it.

@ghost ghost assigned aleks-f Dec 30, 2012
@aleks-f
Copy link
Member

aleks-f commented Dec 30, 2012

Thanks, fixed:

7094df5

@aleks-f aleks-f closed this as completed Dec 30, 2012
obiltschnig pushed a commit that referenced this issue Jun 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants