Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Android should use isfinite, isinf, isnan and signbit from the std namespace #51

Closed
dront78 opened this issue Jan 4, 2013 · 2 comments
Closed

Android should use isfinite, isinf, isnan and signbit from the std namespace #51

dront78 opened this issue Jan 4, 2013 · 2 comments
Assignees
@aleks-f
Milestone
Release 1.5.1

Comments

@dront78
Copy link

dront78 commented Jan 4, 2013

https://bugs.webkit.org/show_bug.cgi?id=37948

same here with latest ndk and poco 1.4.5, overwise it fails on
Foundation/include/Poco/FPEnvironment_DUMMY.h

to fix a problem

include

inline bool FPEnvironmentImpl::isInfiniteImpl(float value)
{
return std::isinf(value) != 0;
}

inline bool FPEnvironmentImpl::isInfiniteImpl(double value)
{
return std::isinf(value) != 0;
}

inline bool FPEnvironmentImpl::isInfiniteImpl(long double value)
{
return std::isinf((double) value) != 0;
}
aleks-f added a commit that referenced this issue Jan 5, 2013
@aleks-f
GH #51: Android should use isfinite, isinf, isnan and signbit from th…
9b3fc90 
…e std namespace

GH #51: Android should use isfinite, isinf, isnan and signbit from the
std namespace
@aleks-f
Copy link
Member

aleks-f commented Jan 5, 2013

changed in a separate branch to allow for some more testing:

FP-dummy-android

@ghost ghost assigned aleks-f Jan 5, 2013
@aleks-f
Copy link
Member

aleks-f commented Jan 5, 2013

merged to develop for 1.5.1 release:

9b3fc90

@aleks-f aleks-f closed this as completed Jan 5, 2013
@obiltschnig obiltschnig mentioned this issue Jan 12, 2013
Closed
obiltschnig pushed a commit that referenced this issue Jun 27, 2018
@mkrivos
Merge pull request #51 from pocoproject/develop
fd9a589 
Sync 22.1.2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aleks-f aleks-f

Labels
None yet
Projects
None yet
Milestone
Release 1.5.1
Development

No branches or pull requests
2 participants
@dront78 @aleks-f