New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Signed / unsigned comparison issue in Data\ODBC\include\Poco\Data\ODBC\Extractor.h #87
Comments
Please specify which version you are using. Here's current develop code (i.e. 1.5.1 relase): if (isNullLengthIndicator(_lengths[pos]))
return false;
else
{
//for fixed-length data, buffer must be large enough
//otherwise, driver may write past the end
poco_assert_dbg (_lengths[pos] <= sizeof(T));
val = value;
} |
Hi Aleks, thanks for your response! I'm using current stable release, e.g. 1.4.6, and, therefore, my report refers to that version, sorry for not mentioning it in my original post. Development code (1.5.1) that you pointed me out to has reworked that function and covers the case of Dmitry. |
The only two values (besides the length itself) that can be returned ( see http://msdn.microsoft.com/en-us/library/windows/desktop/ms715441(v=vs.85).aspx ) are SQL_NULL_DATA and SQL_NO_TOTAL. Since SQL_NO_TOTAL only applies to character and binary data, it is handled in specializations of extractManualImpl: if (SQL_NO_TOTAL == len)//unknown length, throw
throw UnknownDataLengthException("Could not determine returned data length.");
if (isNullLengthIndicator(len))
{ ... EDIT: 2/16/03 1705UTC edited code snippet to reflect both values being checked |
Yes, I agree. I was mislead by generic topic on length / indicator values (http://msdn.microsoft.com/en-us/library/windows/desktop/ms713532(v=vs.85).aspx) which applies not only to Therefore the issue is relevant only in current (1.4.6) version and looks to be addressed in 1.5.x. Thanks, |
@obiltschnig : any plans to address this in 1.4.x ? if not, or it was done, let's close it |
Abovementioned file contains the following assertion check inside function:
Unfortunately
len
may very well be negative (e.g.SQL_NULL_DATA
predefined value).In this case signed / unsigned comparison between signed
len
and unsignedsizeof()
result has unexpected behavior (false assertion is raised).This is reproduced in VS 2012 by simplistic sample as well:
Casting
sizeof()
result in place to signed value fixes the issue.The text was updated successfully, but these errors were encountered: