Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ParallelSocketAcceptor virtual functions #93

Closed
flomll opened this issue Feb 18, 2013 · 1 comment
Closed

ParallelSocketAcceptor virtual functions #93

flomll opened this issue Feb 18, 2013 · 1 comment

Comments

@flomll
Copy link

flomll commented Feb 18, 2013

You are not able to inherit from ParallelSocketAcceptor to implement their own createServiceHandler() because the destructor and the method createServiceHandler() are not virtual!!

And a method like nextReactor() is also needed to get the next reactor at the createServiceHandler(). Take a look at the single thread version SocketAcceptor.h

@aleks-f
Copy link
Member

aleks-f commented Feb 18, 2013

Well, we are not perfect. If we were, we'd close the source and do it alone. Would you mind considering an alternative to yelling at us - fixing it and sending a pull request? Maybe contributing an example of inherited Acceptor (I never had need for one).

Thanks.

aleks-f added a commit that referenced this issue Feb 18, 2013
- fixed GH #93: ParallelSocketAcceptor virtual functions
- updated CHANGELOG
@aleks-f aleks-f closed this as completed Feb 18, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants