Skip to content
This repository has been archived by the owner on Nov 14, 2022. It is now read-only.

Update pull_request_template.md #62

Merged
merged 1 commit into from
Nov 3, 2019
Merged

Update pull_request_template.md #62

merged 1 commit into from
Nov 3, 2019

Conversation

vladdoster
Copy link
Collaborator

I felt that the old PR template was rally obtuse. This one is a a lot more succinct and has less check boxes.

Pull Request Template

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • Documentation update
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • test_cast
  • test_response_200

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

I felt that the old PR template was rally obtuse. This one is a a lot more succinct and has less check boxes.
Copy link
Owner

@monuelo monuelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GJ, @vladdoster ;D

@monuelo monuelo merged commit e180a4d into monuelo:dev Nov 3, 2019
@vladdoster vladdoster deleted the patch-2 branch November 3, 2019 19:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants