Allow MarcRecords to be looked up via ISBN #242
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is really cool! Does it make sense to also add this query ability to the |
…esponse of those records grouped by organization
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm just pushing this up because I'll be off for a few days. I don't think this is really tractable in its current path, but maybe somebody could take it and run.
Also don't know if this would be totally useless with #241 🤷
One major hurdle this would have is that records have multiple ISBNs, so we would probably need a separate table for those so we could query effectively on which records had that particular ISBN (which maybe make the graphql option even more attractive).