Skip to content

Commit

Permalink
Big refactoring: automated tests, feed without guid
Browse files Browse the repository at this point in the history
This huge commit is a refactoring to accommodate feeds with episodes
without guid.

Automated tests were added, which also required refactorings.

All the commands related to episodes now rely on an episodeId, which
is a unique way to identify a podcast in memory.

What is saved in the sync storage to identify an episode is an
EpisodeSelector, and the selection has the following priority:
* guid
* title

Other fields can be added in the future and the priority below
guid may change without disruption.
  • Loading branch information
Guilherme Dellagustin committed Apr 19, 2018
1 parent c501ab3 commit 5569eac
Show file tree
Hide file tree
Showing 47 changed files with 3,099 additions and 759 deletions.
1 change: 1 addition & 0 deletions .gitignore
Expand Up @@ -2,3 +2,4 @@ lib
fonts
build_output
bower_components
node_modules
17 changes: 17 additions & 0 deletions .vscode/launch.json
@@ -0,0 +1,17 @@
{
// Use IntelliSense to learn about possible attributes.
// Hover to view descriptions of existing attributes.
// For more information, visit: https://go.microsoft.com/fwlink/?linkid=830387
"version": "0.2.0",
"configurations": [{
"type": "chrome",
"request": "attach",
"name": "Attach Karma Chrome",
"address": "localhost",
"port": 9333,
"pathMapping": {
"/": "${workspaceRoot}",
"/base/": "${workspaceRoot}/"
}
}]
}
13 changes: 12 additions & 1 deletion background/background.html
@@ -1,14 +1,25 @@
<!DOCTYPE html>
<html ng-app="podstationBackgroundApp">
<html>
<script type="text/javascript" src="/lib/jquery.min.js"></script>
<script type="text/javascript" src="/lib/angular.js"></script>
<script type="text/javascript" src="/lib/jsmediatags.min.js"></script>
<script type="text/javascript" src="/lib/podStationNGReuse.min.js"></script>

<!-- Internal reusables (pages and background)-->
<script type="text/javascript" src="/reuse/ng/reuse.js"></script>
<script type="text/javascript" src="/reuse/ng/services/podcastManagerService.js"></script>
<script type="text/javascript" src="/reuse/ng/services/analyticsService.js"></script>
<script type="text/javascript" src="/reuse/ng/services/messageService.js"></script>
<script type="text/javascript" src="/reuse/ng/services/podcastDataService.js"></script>
<script type="text/javascript" src="/reuse/ng/services/dateService.js"></script>
<script type="text/javascript" src="/reuse/comparison.js"></script>
<script type="text/javascript" src="/reuse/messageServiceDefinition.js"></script>

<script type="text/javascript" src="entities/backgroundApp.js"></script>
<script type="text/javascript" src="ng/services/storageService.js"></script>
<script type="text/javascript" src="ng/services/podcastStorageService.js"></script>
<script type="text/javascript" src="ng/services/playlistStorageService.js"></script>
<script type="text/javascript" src="entities/episodeSelector.js"></script>
<script type="text/javascript" src="entities/messageService.js"></script>
<script type="text/javascript" src="entities/notificationManager.js"></script>
<script type="text/javascript" src="entities/optionsManager.js"></script>
Expand Down

0 comments on commit 5569eac

Please sign in to comment.