Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harmony 1178 paged stac 2 #30

Merged
merged 2 commits into from
May 31, 2022

Conversation

indiejames
Copy link
Contributor

Github Issue: N/A

Description

Adds support for paged STAC catalog input (HARMONY-1178). This enables better scaling to many items as no one catalog has more items than the page size.

Overview of work done

  • Added support for paged STAC catalog input, i.e., catalogs that have 'next' and 'prev' links.
  • Updated code to use harmony-service-lib v1.0.16.

Overview of verification done

  • Added tests using paged STAC catalog input

Overview of integration done

  • Built image and deployed in local Harmony.
  • Issued the following query (with Harmony AGGREGATE_STAC_CATALOG_MAX_PAGE_SIZE=2 to trigger paged catalogs)
http://localhost:3000/C1234208438-POCLOUD/ogc-api-coverages/1.0.0/collections/all/coverage/rangeset?maxResults=10&concatenate=true
  • Verified that generated input catalogs were paged
  • Opened resulting nc4 file in Panoply 4.10.11 and plotted 'bathymetry':

Screen Shot 2022-05-27 at 2 35 58 PM

PR checklist:

  • Linted
  • Updated unit tests
  • Updated changelog
  • Integration testing

See Pull Request Review Checklist for pointers on reviewing this pull request

@frankinspace frankinspace requested a review from a team May 27, 2022 21:25
Copy link
Contributor

@skorper skorper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't run our actions on this branch so I manually linted/tested -- everything looks good. Thanks @indiejames !

@skorper skorper merged commit 1f99301 into podaac:develop May 31, 2022
@indiejames indiejames deleted the harmony-1178-paged-STAC-2 branch May 31, 2022 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants