Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/issue-6: History metadata #7

Merged
merged 4 commits into from
Nov 22, 2021
Merged

feature/issue-6: History metadata #7

merged 4 commits into from
Nov 22, 2021

Conversation

skorper
Copy link
Contributor

@skorper skorper commented Nov 22, 2021

Github Issue: #6

Description

Harmony services need to modify history_json attribute. See https://wiki.earthdata.nasa.gov/display/TRT/In-File+Provenance+Metadata+-+TRT-42

Overview of work done

history_json attribute is added to Concise result. If any parent files contain the history_json attribute, those will be added to the history_json attribute for the result. This means an L2SS-Py + Concise chain result should contain history_json entries from both services.

Overview of verification done

Added a unit test checking for history_json. Tested with single and multi-core mode, and also checked that it works when there is existing history_json metadata in the input files.

Overview of integration done

No integration testing has been done.

PR checklist:

  • Linted
  • Updated unit tests
  • Updated changelog
  • Integration testing

See Pull Request Review Checklist for pointers on reviewing this pull request

@skorper skorper requested a review from a team November 22, 2021 20:13
@skorper skorper merged commit 62ac5f4 into develop Nov 22, 2021
@skorper skorper deleted the feature/issue-6 branch November 22, 2021 22:45
@skorper skorper restored the feature/issue-6 branch November 29, 2021 22:35
@skorper skorper deleted the feature/issue-6 branch May 27, 2022 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants