Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Errno 17] File exists #46

Closed
frankinspace opened this issue Feb 24, 2022 · 0 comments · Fixed by #47
Closed

[Errno 17] File exists #46

frankinspace opened this issue Feb 24, 2022 · 0 comments · Fixed by #47

Comments

@frankinspace
Copy link
Member

Ran into an error when testing phase 2 dataset downloads in dev.

Because we have multiple collections that share a similar destination path (found this error with MODIS_AQUA_L3_SST_THERMAL_DAILY_4KM_NIGHTTIME_V2019.0), there is a chance that two instances of data-subscriber both try to call makedirs for the same directory at the same time. This results in one of them being successful and the other one throws an error [Errno 17] File exists.

Easy fix is to use exist_ok=True parameter to ignore an already existing directory.
frankinspace added a commit that referenced this issue Feb 24, 2022
@frankinspace
Ignore error if directory already exists
3569d98 
Fixes #46
@frankinspace frankinspace mentioned this issue Feb 24, 2022
Merged
mike-gangl pushed a commit that referenced this issue Feb 24, 2022
@frankinspace
Ignore error if directory already exists (#47)
4e2f967 
* Ignore error if directory already exists

Fixes #46

* issues/46: Ignore errors if destination directory already exists.

Co-authored-by: Frank Greguska <Francis.Greguska@jpl.nasa.gov>
@mike-gangl mike-gangl linked a pull request Feb 24, 2022 that will close this issue
Ignore error if directory already exists #47
Merged
mike-gangl added a commit that referenced this issue Feb 28, 2022
@mike-gangl @sappjw-noaa
@mgangl @frankinspace
Develop (#52)
e73cde3 
* Don't consume all arguments after --extensions

This behavior is now more like other utilities where specifying the flag
multiple times extends the value of the argument.  For example,
    -e '.nc .h5 .zip'
becomes
    -e '.nc' -e '.h5' -e '.zip'

This is less fragile for the user and possibly less confusing how the
argument should be formatted on the command line.

* Add ability to execute arbitrary commands on each downloaded file

I did it this way so each file could be compressed without hard-coding
the compression algorithm. But I could see this being used to run a
pre-processing script on each downloaded file.

* updated README and tests for additive -e examples

* force 'action'

* merged code for extensions, process call, and updated documentation

* fix for #28

* updated CHANGELOG

* Issue 33 (#35)

* Develop (#32)

* Don't consume all arguments after --extensions

This behavior is now more like other utilities where specifying the flag
multiple times extends the value of the argument.  For example,
    -e '.nc .h5 .zip'
becomes
    -e '.nc' -e '.h5' -e '.zip'

This is less fragile for the user and possibly less confusing how the
argument should be formatted on the command line.

* Add ability to execute arbitrary commands on each downloaded file

I did it this way so each file could be compressed without hard-coding
the compression algorithm. But I could see this being used to run a
pre-processing script on each downloaded file.

* updated README and tests for additive -e examples

* force 'action'

* merged code for extensions, process call, and updated documentation

* fix for #28

* updated CHANGELOG

Co-authored-by: Joe Sapp <joe.sapp@noaa.gov>
Co-authored-by: mgangl <mike.gangl@gmail.com>

* closes #33
added 'files to download' to non-verbose output

* updated changelog

Co-authored-by: Joe Sapp <joe.sapp@noaa.gov>
Co-authored-by: mgangl <mike.gangl@gmail.com>

* updated changelog to reflect accurate versions released

* version bump for master delivery

* Bulk download capability (#45)

* added pypi release badge to README

* began separating out functionality for data downloader

* 1.7.2 merge into develop (#43)

* Don't consume all arguments after --extensions

This behavior is now more like other utilities where specifying the flag
multiple times extends the value of the argument.  For example,
    -e '.nc .h5 .zip'
becomes
    -e '.nc' -e '.h5' -e '.zip'

This is less fragile for the user and possibly less confusing how the
argument should be formatted on the command line.

* Add ability to execute arbitrary commands on each downloaded file

I did it this way so each file could be compressed without hard-coding
the compression algorithm. But I could see this being used to run a
pre-processing script on each downloaded file.

* updated README and tests for additive -e examples

* force 'action'

* merged code for extensions, process call, and updated documentation

* fix for #28

* updated CHANGELOG

* Issue 33 (#35)

* Develop (#32)

* Don't consume all arguments after --extensions

This behavior is now more like other utilities where specifying the flag
multiple times extends the value of the argument.  For example,
    -e '.nc .h5 .zip'
becomes
    -e '.nc' -e '.h5' -e '.zip'

This is less fragile for the user and possibly less confusing how the
argument should be formatted on the command line.

* Add ability to execute arbitrary commands on each downloaded file

I did it this way so each file could be compressed without hard-coding
the compression algorithm. But I could see this being used to run a
pre-processing script on each downloaded file.

* updated README and tests for additive -e examples

* force 'action'

* merged code for extensions, process call, and updated documentation

* fix for #28

* updated CHANGELOG

Co-authored-by: Joe Sapp <joe.sapp@noaa.gov>
Co-authored-by: mgangl <mike.gangl@gmail.com>

* closes #33
added 'files to download' to non-verbose output

* updated changelog

Co-authored-by: Joe Sapp <joe.sapp@noaa.gov>
Co-authored-by: mgangl <mike.gangl@gmail.com>

* updated changelog to reflect accurate versions released

* version bump for master delivery

Co-authored-by: Joe Sapp <joe.sapp@noaa.gov>
Co-authored-by: mgangl <mike.gangl@gmail.com>

* fixed tests

* removed erroneous printouts for pytest fixes

* fixed some bugs
closes #39
closes #40

* Update README.md

* updates for flake8

* fixed issue with time_offset variables, added manual tests

* flake8 updates for access, subscriber

* added downloader tests, flake8 updates for download client

Co-authored-by: Joe Sapp <joe.sapp@noaa.gov>
Co-authored-by: mgangl <mike.gangl@gmail.com>

* updated tests

* fixed path issue for built python command line tooling

* Ignore error if directory already exists (#47)

* Ignore error if directory already exists

Fixes #46

* issues/46: Ignore errors if destination directory already exists.

Co-authored-by: Frank Greguska <Francis.Greguska@jpl.nasa.gov>

* Issues/44 (#48)

* Added functionality to name .update file to .update__<COLLECTION> so that the same directory can be re-used.
Added tests to fix this functionality
closes #44

* flake8 fixes

* added updates to .update file

* Issues/41 (#50)

* added cycle based downloads

* udpated changelog

* 180 docs (#51)

* added changelog info for 1.80, created initial markdown files

* added subsriber/downloader links

* added documentation

* Added downloader/subscriber specific docs.
fixed some issues with imports

* Update README.md

Co-authored-by: Joe Sapp <joe.sapp@noaa.gov>
Co-authored-by: mgangl <mike.gangl@gmail.com>
Co-authored-by: Frank Greguska <89428916+frankinspace@users.noreply.github.com>
Co-authored-by: Frank Greguska <Francis.Greguska@jpl.nasa.gov>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ignore error if directory already exists podaac/data-subscriber
1 participant
@frankinspace