Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing unit test to correct value returned by CMR #155

Merged
merged 1 commit into from
Feb 3, 2024

Conversation

skorper
Copy link
Contributor

@skorper skorper commented Feb 1, 2024

Updated failing test.

>       assert results['hits'] == 3751
E       assert 3762 == 3751

tests\test_subscriber.py:88: AssertionError
=========================== short test summary info ===========================
FAILED tests/test_subscriber.py::test_search_after - assert [37](https://github.com/podaac/data-subscriber/actions/runs/7745910236/job/21122928083?pr=154#step:7:38)62 == 3751
================ 1 failed, 19 passed, 12 deselected in 13.95s =================
Error: Process completed with exit code 1.

The CMR query being executed by this test is now returning 3762 hits, not 3751.

@skorper skorper merged commit 7f01419 into release/1.15.0 Feb 3, 2024
skorper added a commit that referenced this pull request Feb 5, 2024
* initial implementaiton of subset code

* added tests, more updates

* removed skip_errors (not implemented yet)

* Upgrade to harmony-py 0.4.9

* subsetting capability initial commit

* update spacing

* Update docs

* update poetry lock

* upgrade to poetry 1.5.1 (latest)

* fix failing checksum test

* fixed regression test issues

* bump poetry version in second gh action file

* Update poetry version to fix build issue

* bump poetry version

* bump poetry version

* bump version to 1.15.0

* bump version to 1.15.0

* Fixed bug introduced in issues/36 where valid bboxes were raising an exception

* bump version to 1.15.0-a.2

* Add error if both cycle and subset are provided

* If verbose, output Harmony job details. Also allow temporal and spatial bounds to be OPTIONAL so users don't have to provide these values.

* Added log message to indicate harmony job is submitted and waiting

* fixed cycle check typo

* dry run + subset

* idl check

* bump version to a3

* fix failing unit test to correct value returned by CMR (#155)

---------

Co-authored-by: mike-gangl <michael.e.gangl@jpl.nasa.gov>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants