Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add checks for pre-existing files to downloader #67

Merged
merged 2 commits into from
Apr 27, 2022

Conversation

wveit
Copy link
Contributor

@wveit wveit commented Apr 26, 2022

Addresses Issue #17 - adding to what was done in PR 63

Changes:

  • The downloader will skip downloading a file if the file already exists (and its checksum matches with CMR).
  • Also adds the --force/-f flag to force the downloader download files - even when they already exist.
  • Added documentation to the Downloader.md file, and changed the documentation for this feature in the Subscriber.md file. (The new description makes more sense to me, but let me know any suggestions you might have on this).

@mike-gangl mike-gangl merged commit 60f2bce into develop Apr 27, 2022
@mike-gangl mike-gangl deleted the add-checksum-checks-to-downloader branch April 28, 2022 00:00
mike-gangl added a commit that referenced this pull request Apr 28, 2022
* Change print statements to log statements

* Fix flake errors

* Add retry logic for 500 and 401 errors from CMR

* Subscriber check if file exists before downloading

Prevents re-downloading files (e.g. in case previous run
failed because of other file failures).

If the subscriber sees a file already exists, it will also calculate
the file checksum and see if it matches the checksum in
CMR. If the checcksum doesn't match, it will re-download.

There is now a --force/-f option that will cause subscriber
to re-download even if the file exists and is up to date.

Issue #17

* Issues/15 (#65)

* updated get_search to include verbose option, not entire 'args' option

* added search after functionality to podaac access; removed scroll from initial parameters

* updated changelog

* closes #15

* Update python-app.yml

added netrc creation for future use of regression tests.

* Add checks for pre-existing files to downloader (#67)

* Check if file exists before download - downloader

* Update documentation

Co-authored-by: Wilbert Veit <wilbert.e.veit@jpl.nasa.gov>

* Programmatic Regression Testing (#66)

* added programmatice regression testing. currently relies on a valid .netrc file, refactoring might be needed to manually add a user/password to the CMR/TEA downloads

* Update python-app.yml

* updated regression tests, readied 1.9.0 version

* added -f option test to downloader regression

* Update python-app.yml

Co-authored-by: Joe Sapp <joe.sapp@noaa.gov>
Co-authored-by: mgangl <mike.gangl@gmail.com>
Co-authored-by: Frank Greguska <Francis.Greguska@jpl.nasa.gov>
Co-authored-by: Wilbert Veit <wilbert.e.veit@jpl.nasa.gov>
Co-authored-by: Wilbert Veit <wilbertveit@rocketmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants