Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/swodlr UI 114 - implement endpoint for My Data page filtering #116

Merged
merged 8 commits into from
Jun 21, 2024
Merged

Feature/swodlr UI 114 - implement endpoint for My Data page filtering #116

merged 8 commits into from
Jun 21, 2024

Conversation

jbyrne6
Copy link
Contributor

@jbyrne6 jbyrne6 commented Jun 20, 2024

Changes

filtering api is being used for the following properties

  • cycle
  • pass
  • scene
  • outputGranuleExtentFlag
  • outputSamplingGridType
  • startDate,
  • endDate

filtering api is not being used for the following properties because api does not support it yet

  • status
  • rasterResolution
  • utmZoneAdjust
  • mgrsBandAdjust

@jbyrne6 jbyrne6 added the enhancement New feature or request label Jun 20, 2024
@jbyrne6 jbyrne6 self-assigned this Jun 20, 2024
@jbyrne6 jbyrne6 linked an issue Jun 20, 2024 that may be closed by this pull request
Update Filter using new backend filter options #114
Closed
joshgarde
joshgarde requested changes Jun 20, 2024
View reviewed changes
Copy link
Member

@joshgarde joshgarde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, good work - performance is getting better and better with every iteration

src/components/history/HistoryFilters.tsx Outdated Show resolved Hide resolved
src/components/history/HistoryFilters.tsx Outdated Show resolved Hide resolved
src/constants/graphqlQueries.ts Outdated Show resolved Hide resolved
src/constants/graphqlQueries.ts Outdated Show resolved Hide resolved
@jbyrne6 jbyrne6 requested a review from joshgarde June 21, 2024 16:44
joshgarde
joshgarde approved these changes Jun 21, 2024
View reviewed changes
Copy link
Member

@joshgarde joshgarde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - lgtm 👍

@viviant100 viviant100 merged commit 7773197 into develop Jun 21, 2024
4 checks passed
@viviant100 viviant100 deleted the feature/swodlr-ui-114 branch June 21, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshgarde joshgarde joshgarde approved these changes

@viviant100 viviant100 Awaiting requested review from viviant100

@frankinspace frankinspace Awaiting requested review from frankinspace

Assignees

@jbyrne6 jbyrne6

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Filter using new backend filter options
3 participants
@jbyrne6 @joshgarde @viviant100