Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add notebook to query cmr and get s3 links for a collections #139

Merged
merged 3 commits into from
Aug 22, 2023

Conversation

sliu008
Copy link
Contributor

@sliu008 sliu008 commented Aug 4, 2023

  • Created a notebook to show how to get list of s3 links from a cmr query

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@sliu008
Copy link
Contributor Author

sliu008 commented Aug 4, 2023

@jinbow
Copy link
Contributor

jinbow commented Aug 8, 2023

@sliu008, This is great. My suggestions for improvement:

  1. Add a parameter search by short_name
  2. Capability of using .netrc file for auto-authentication
  3. Add a description how to get the EDL token.
  4. Add a description where to find the concept id

@sliu008
Copy link
Contributor Author

sliu008 commented Aug 8, 2023

@sliu008, This is great. My suggestions for improvement:

  1. Add a parameter search by short_name
  2. Capability of using .netrc file for auto-authentication
  3. Add a description how to get the EDL token.
  4. Add a description where to find the concept id

@jinbow I made the suggest changes you wanted, i added code that gets the EDL token and a collection concept id by a collection short name.

@sliu008 sliu008 requested a review from jamesfwood August 8, 2023 23:32
@jinbow
Copy link
Contributor

jinbow commented Aug 22, 2023

Simon, this is great. I tested it and it worked on my laptop, beautiful! One minor request. Can you change the last line to "display(s3_links)"? It will produce nicer printout list.

@sliu008 sliu008 merged commit 686df23 into master Aug 22, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants