Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we seed staging on every deploy? #52

Closed
deivid-rodriguez opened this issue Jun 5, 2018 · 3 comments
Closed

Should we seed staging on every deploy? #52

deivid-rodriguez opened this issue Jun 5, 2018 · 3 comments

Comments

@deivid-rodriguez
Copy link
Contributor

Currently the seed process is very slow and makes consecutive deploys fail.

I was thinking that we could pg_dump a brand new seeded DB, and then pg_restore on deployment, but then I realized that seeds in decidim don't lead to a known fixed state, but instead seed random data so I'm not sure reseeding actually buys us much, since the final state will be "random" anyways. Should we instead leave staging data untouched?

@leio10
Copy link
Contributor

leio10 commented Jun 6, 2018

I'll be working on seeds these days. The idea of reseeding on every deploy is to have a fresh installation with every change, but I'm open to change it. Also, after we deploy to production we will need a place to check if changes work well over existing data.

@deivid-rodriguez
Copy link
Contributor Author

Actually I feel not deleting and reseeding test data better checks "if changes work over existing data". Because it will exercise migrations over the existing data (if the deploy includes migrations) and potentially surface data migration problems.

The thing is I'm not sure if a freshly seeded DB on every deploy buys us anything. Not seeding buys us a lot of time on every deploy...

@leio10
Copy link
Contributor

leio10 commented Jun 7, 2018

Fixed on #55

@leio10 leio10 closed this as completed Jun 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants