Hide authorizations

.circleci/config.yml

@@ -6,6 +6,13 @@ jobs:
   main:
     docker:
       - image: decidim/decidim@sha256:c0588c1f425fa2433733978fbfa147b4e6cc54be9f6ac4583920158d6a408972
+        environment:
+          DATABASE_USERNAME: postgres
+          CENSUS_URL: http://mycensus:3001
+
+      - image: postgres
+        environment:
+          POSTGRES_USER: postgres
 
     steps:
       - checkout
@@ -36,13 +43,17 @@ jobs:
           paths:
             - node_modules
 
+      - run:
+          name: Create and migrate DB
+          command: bin/rails db:create db:migrate
+
       - run:
           name: Run tests
-          command: bundle exec rspec
+          command: bin/rspec
 
       - run:
           name: Run rubocop
-          command: bundle exec rubocop
+          command: bin/rubocop
 
       - run:
           name: Run npm lints

.gitignore

@@ -20,6 +20,9 @@
 # Ignore public uploads
 public/uploads
 
+# rspec failure tracking
+.rspec-failures
+
 # rubocop cached remote config
 .rubocop-https---raw-githubusercontent-com-decidim-decidim-0-11-stable--rubocop-yml
 .rubocop-https---raw-githubusercontent-com-decidim-decidim-0-11-stable--rubocop-rails-yml

app/assets/stylesheets/decidim.scss

@@ -79,3 +79,7 @@ $secondary3: #a7e6d9;
     margin-bottom: 1rem;
   }
 }
+
+a[href="/authorizations"]{
+  display: none;
+}

config/initializers/assets.rb

@@ -14,3 +14,6 @@
 # application.js, application.css, and all non-JS/CSS in the app/assets
 # folder are already added.
 # Rails.application.config.assets.precompile += %w( admin.js admin.css )
+
+# No precompilation on demand on first request
+Rails.application.config.assets.check_precompiled_asset = false

config/routes.rb

@@ -3,6 +3,8 @@
 Rails.application.routes.draw do
   mount LetterOpenerWeb::Engine, at: "/letter_opener" if Rails.env.development?
 
+  get "/authorizations" => redirect("/census_account")
+
   mount Decidim::Core::Engine => "/"
   # For details on the DSL available within this file, see http://guides.rubyonrails.org/routing.html
 end

decidim-module-census_connector/.gitignore

@@ -1,7 +1,4 @@
 /tmp/
 
-# rspec failure tracking
-.rspec-failures
-
 # default test application
 spec/decidim_dummy_app

decidim-module-crowdfundings/.gitignore

@@ -1,5 +1,2 @@
-# rspec failure tracking
-.rspec-failures
-
 # default test application
 spec/decidim_dummy_app

decidim-module-gravity_forms/.gitignore

@@ -1,5 +1,2 @@
-# rspec failure tracking
-.rspec-failures
-
 # default test application
 spec/decidim_dummy_app

decidim-module-votings/.gitignore

@@ -1,5 +1,2 @@
-# rspec failure tracking
-.rspec-failures
-
 # default test application
 spec/decidim_dummy_app

spec/rails_helper.rb

@@ -0,0 +1,76 @@
+# frozen_string_literal: true
+
+ENV["RAILS_ENV"] ||= "test"
+
+# This file is copied to spec/ when you run "rails generate rspec:install"
+require "spec_helper"
+
+require File.expand_path("../config/environment", __dir__)
+
+# Prevent database truncation if the environment is production
+abort("The Rails environment is running in production mode!") if Rails.env.production?
+
+require "rspec/rails"
+
+# Add additional requires below this line. Rails is not loaded until this point!
+
+# Requires supporting ruby files with custom matchers and macros, etc, in
+# spec/support/ and its subdirectories. Files matching `spec/**/*_spec.rb` are
+# run as spec files by default. This means that files in spec/support that end
+# in _spec.rb will both be required and run as specs, causing the specs to be
+# run twice. It is recommended that you do not name files matching this glob to
+# end with _spec.rb. You can configure this pattern with the --pattern
+# option on the command line or in ~/.rspec, .rspec or `.rspec-local`.
+
+require "decidim/dev/test/rspec_support/capybara"
+require "factory_bot_rails" # can be removed when required by decidim
+require "decidim/dev/test/rspec_support/factory_bot"
+require "decidim/dev/test/rspec_support/warden"
+
+require "decidim/core/test/factories"
+
+# Checks for pending migrations and applies them before tests are run.
+# If you are not using ActiveRecord, you can remove this line.
+ActiveRecord::Migration.maintain_test_schema!
+
+RSpec.configure do |config|
+  # Remove this line if you're not using ActiveRecord or ActiveRecord fixtures
+  config.fixture_path = "#{::Rails.root}/spec/fixtures"
+
+  # If you're not using ActiveRecord, or you'd prefer not to run each of your
+  # examples within a transaction, remove the following line or assign false
+  # instead of true.
+  config.use_transactional_fixtures = true
+
+  # RSpec Rails can automatically mix in different behaviours to your tests
+  # based on their file location, for example enabling you to call `get` and
+  # `post` in specs under `spec/controllers`.
+  #
+  # You can disable this behaviour by removing the line below, and instead
+  # explicitly tag your specs with their type, e.g.:
+  #
+  #     RSpec.describe UsersController, :type => :controller do
+  #       # ...
+  #     end
+  #
+  # The different available types are documented in the features, such as in
+  # https://relishapp.com/rspec/rspec-rails/docs
+  config.infer_spec_type_from_file_location!
+
+  # Filter lines from Rails gems in backtraces.
+  config.filter_rails_from_backtrace!
+  # arbitrary gems may also be filtered via:
+  # config.filter_gems_from_backtrace("gem name")
+
+  config.around do |example|
+    begin
+      original_locales = I18n.available_locales
+
+      I18n.available_locales = original_locales + [:en]
+
+      example.run
+    ensure
+      I18n.available_locales = original_locales
+    end
+  end
+end

spec/spec_helper.rb

@@ -0,0 +1,94 @@
+# frozen_string_literal: true
+
+# This file was generated by the `rails generate rspec:install` command. Conventionally, all
+# specs live under a `spec` directory, which RSpec adds to the `$LOAD_PATH`.
+# The generated `.rspec` file contains `--require spec_helper` which will cause
+# this file to always be loaded, without a need to explicitly require it in any
+# files.
+#
+# Given that it is always loaded, you are encouraged to keep this file as
+# light-weight as possible. Requiring heavyweight dependencies from this file
+# will add to the boot time of your test suite on EVERY test run, even for an
+# individual file that may not need all of that loaded. Instead, consider making
+# a separate helper file that requires the additional dependencies and performs
+# the additional setup, and require it from the spec files that actually need
+# it.
+#
+# See http://rubydoc.info/gems/rspec-core/RSpec/Core/Configuration
+RSpec.configure do |config|
+  # rspec-expectations config goes here. You can use an alternate
+  # assertion/expectation library such as wrong or the stdlib/minitest
+  # assertions if you prefer.
+  config.expect_with :rspec do |expectations|
+    # This option will default to `true` in RSpec 4. It makes the `description`
+    # and `failure_message` of custom matchers include text for helper methods
+    # defined using `chain`, e.g.:
+    #     be_bigger_than(2).and_smaller_than(4).description
+    #     # => "be bigger than 2 and smaller than 4"
+    # ...rather than:
+    #     # => "be bigger than 2"
+    expectations.include_chain_clauses_in_custom_matcher_descriptions = true
+  end
+
+  # rspec-mocks config goes here. You can use an alternate test double
+  # library (such as bogus or mocha) by changing the `mock_with` option here.
+  config.mock_with :rspec do |mocks|
+    # Prevents you from mocking or stubbing a method that does not exist on
+    # a real object. This is generally recommended, and will default to
+    # `true` in RSpec 4.
+    mocks.verify_partial_doubles = true
+  end
+
+  # This option will default to `:apply_to_host_groups` in RSpec 4 (and will
+  # have no way to turn it off -- the option exists only for backwards
+  # compatibility in RSpec 3). It causes shared context metadata to be
+  # inherited by the metadata hash of host groups and examples, rather than
+  # triggering implicit auto-inclusion in groups with matching metadata.
+  config.shared_context_metadata_behavior = :apply_to_host_groups
+
+  # This allows you to limit a spec run to individual examples or groups
+  # you care about by tagging them with `:focus` metadata. When nothing
+  # is tagged with `:focus`, all examples get run. RSpec also provides
+  # aliases for `it`, `describe`, and `context` that include `:focus`
+  # metadata: `fit`, `fdescribe` and `fcontext`, respectively.
+  config.filter_run_when_matching :focus
+
+  # Allows RSpec to persist some state between runs in order to support
+  # the `--only-failures` and `--next-failure` CLI options. We recommend
+  # you configure your source control system to ignore this file.
+  config.example_status_persistence_file_path = ".rspec-failures"
+
+  # Limits the available syntax to the non-monkey patched syntax that is
+  # recommended. For more details, see:
+  #   - http://rspec.info/blog/2012/06/rspecs-new-expectation-syntax/
+  #   - http://www.teaisaweso.me/blog/2013/05/27/rspecs-new-message-expectation-syntax/
+  #   - http://rspec.info/blog/2014/05/notable-changes-in-rspec-3/#zero-monkey-patching-mode
+  config.disable_monkey_patching!
+
+  # Many RSpec users commonly either run the entire suite or an individual
+  # file, and it's useful to allow more verbose output when running an
+  # individual spec file.
+  if config.files_to_run.one?
+    # Use the documentation formatter for detailed output,
+    # unless a formatter has already been configured
+    # (e.g. via a command-line flag).
+    config.default_formatter = "doc"
+  end
+
+  # Print the 10 slowest examples and example groups at the
+  # end of the spec run, to help surface which specs are running
+  # particularly slow.
+  config.profile_examples = 10
+
+  # Run specs in random order to surface order dependencies. If you find an
+  # order dependency and want to debug it, you can fix the order by providing
+  # the seed, which is printed after each run.
+  #     --seed 1234
+  config.order = :random
+
+  # Seed global randomization in this process using the `--seed` CLI option.
+  # Setting this allows you to use `--seed` to deterministically reproduce
+  # test failures related to randomization by passing the same `--seed` value
+  # as the one that triggered the failure.
+  Kernel.srand config.seed
+end

spec/system/authorizations_spec.rb

@@ -0,0 +1,25 @@
+# frozen_string_literal: true
+
+require "rails_helper"
+
+RSpec.describe "Census authorization", type: :system do
+  let(:organization) { create(:organization, available_authorizations: ["census"]) }
+  let(:user) { create(:user, :confirmed, organization: organization) }
+
+  before do
+    switch_to_host(organization.host)
+    login_as user, scope: :user
+  end
+
+  it "redirects the authorizations tab to the census account" do
+    visit "/authorizations"
+
+    expect(page).to have_current_path("/census_account")
+  end
+
+  it "hides the authorizations tab" do
+    visit "/account"
+
+    expect(page).to have_no_link("Autorizaciones")
+  end
+end