Skip to content
This repository has been archived by the owner on May 14, 2024. It is now read-only.

Fix compatibility with stimulus_reflex 3.5.0.rc4 #21

Closed
dacook opened this issue Mar 21, 2024 · 1 comment
Closed

Fix compatibility with stimulus_reflex 3.5.0.rc4 #21

dacook opened this issue Mar 21, 2024 · 1 comment

Comments

@dacook
Copy link

dacook commented Mar 21, 2024

The latest version of StimulusReflex causes the build_reflex method to fail, due to incorrect method arguments.

All specs fail with the follow error and backtrace:

      ArgumentError:
        missing keyword: :reflex_data

      # /Users/xxxx/.rbenv/versions/3.1.4/lib/ruby/gems/3.1.0/gems/stimulus_reflex-3.5.0.rc4/lib/stimulus_reflex/reflex.rb:28:in `initialize'
      # /Users/xxxx/.rbenv/versions/3.1.4/lib/ruby/gems/3.1.0/gems/stimulus_reflex-3.5.0.rc4/lib/stimulus_reflex/cable_readiness.rb:8:in `initialize'
      # /Users/xxxx/.rbenv/versions/3.1.4/lib/ruby/gems/3.1.0/gems/stimulus_reflex_testing-0.3.0/lib/stimulus_reflex/test_case.rb:34:in `new'
      # /Users/xxxx/.rbenv/versions/3.1.4/lib/ruby/gems/3.1.0/gems/stimulus_reflex_testing-0.3.0/lib/stimulus_reflex/test_case.rb:34:in `build_reflex'

It appears due to the change here:
stimulusreflex/stimulus_reflex@3137a0f?diff=unified&w=1
@dacook dacook mentioned this issue Mar 21, 2024
Closed
@dacook dacook mentioned this issue Apr 10, 2024
Merged
@dacook
Copy link
Author

dacook commented May 14, 2024

Fixed in #22

@dacook dacook closed this as completed May 14, 2024
dacook added a commit to openfoodfoundation/openfoodnetwork that referenced this issue May 14, 2024
@dacook
Bump stimulus_reflex_testing to latest
854091e 
It contains a fix for stimulus_reflex 3.5.0-rc4, but hasn't been released yet.
podia/stimulus_reflex_testing#21

Now the user reflex spec works, but the products spec needs another fix. But we plan to remove it soon anyway.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dacook