Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

State of this Mac fork #4

Closed
rmtew opened this issue Jun 17, 2015 · 9 comments
Closed

State of this Mac fork #4

rmtew opened this issue Jun 17, 2015 · 9 comments

Comments

@rmtew
Copy link

rmtew commented Jun 17, 2015

Hi,

I'm replacing jice as the libtcod maintainer. People have been mentioning to me that the Mac support isn't working for them. I don't have a Mac so I thought I'd ask here, as it seems to have recent changes.

The end result I am looking for is for any Mac developers to at least be able to compile their own version, and better yet some way to get builds done (ideally with scripting language bindings) so that Mac users get the same level of accessibility as Windows users.

What are your thought on the state of things Mac-wise?

@podiki
Copy link
Owner

podiki commented Jun 17, 2015

Hello @rmtew

Thanks for finding me. To be honest I didn't get far in using libtcod as I got distracted by other programming projects, though doing a rougelike is still in the back of my mind. Around the same time it seemed that the libtcod library really stopped development, but I'm very glad to hear you are picking it up.

This Mac port compiles fine, and the samples work at least. I can't remember what else I tried, but I think the libtcod tutorial in python worked too. I also think I got the SDL2 surface rendering working (hopefully this repository is up to date with what I messed around with, I think it is). So I think things should work fine if one clones this repository and has the necessary libraries. I really should add a readme, but it's just a few things to pull in from homebrew and all is good. I might be a few commits behind the last stuff jice added, but I believe it was very minor or not relevant for Mac.

All that being said, I'd be happy to try to keep this Mac port maintained. At the very least I can keep up to date with upstream or provide what I did here to you. Honestly, it's basically what is in that Mac thread from the forum, not much else. So we can work out what's best since it still works. The few commits here should be all you need to reproduce the changes, and in the end most of it came down to some library paths needing to be made consistent.

Let me know what you want to do, and feel free to direct people here in the mean time.

@rmtew
Copy link
Author

rmtew commented Jun 17, 2015

What was the problem with SDL2 surface rendering?

@podiki
Copy link
Owner

podiki commented Jun 17, 2015

If I'm remembering it was just that it is done slightly differently, so you can't just use SDL1 code. Didn't take too long to figure it out, and have a minimal working example (just an image background and one for the player, for instance, as in a tile engine would use).

@rmtew
Copy link
Author

rmtew commented Jun 17, 2015

I'm not sure I understand what the surface changes might be and can't find them. I avoided use of surfaces in the original SDL2 changes, as they were discouraged due to being extremely slow.

Do the local changes here beyond what's needed to get Mac support working, provide a different API to a programmer than the main repo? If so, then the best approach might be to have the specific Mac support changes added to the main repo directly again.

@podiki
Copy link
Owner

podiki commented Jun 17, 2015

Sorry, it has been a while and I just looked back at some test code now. The changes for SDL2 image rendering is not on libtcod's end. It's on the developer's end if they want to use SDL2 versus SDL1, since they do this differently. Like I said, I was testing it to do some tiling, it is not a libtcod change.

For Mac + SDL2 support then, there are few includes that had to be changed (and should be checked for consistency with Windows/Linux) and then the makefiles. Pretty easy, and should be spelled out in the few commits on this repo, as well as the forum thread where the actual work came from.

@podiki
Copy link
Owner

podiki commented Nov 5, 2015

@rmtew Any updates on getting Mac support back into upstream libtcod?

@rmtew
Copy link
Author

rmtew commented Nov 5, 2015

See reply to comment in libtcod issue.

On Fri, Nov 6, 2015 at 7:34 AM, John notifications@github.com wrote:

@rmtew https://github.com/rmtew Any updates on getting Mac support back
into upstream libtcod?


Reply to this email directly or view it on GitHub
#4 (comment).

@podiki
Copy link
Owner

podiki commented Nov 5, 2015

Thanks. Sorry for the cross posting. I'll keep this issue open here and update it once things are resolved, either keeping this repo open for the Mac version, or folding it in with the official libtcod on BitBucket.

@podiki
Copy link
Owner

podiki commented Feb 22, 2017

I have no problem building the current version of upstream libtcod on mac. I've updated the readme here with instructions and to refer back to libtcod proper. I will keep this up for now just in case anyone needs it.

@podiki podiki closed this as completed Feb 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants