minor improvements: silent option for app requests + fix external_id …

models/PodioApp.php

@@ -77,22 +77,22 @@ public static function get_for_space($space_id, $attributes = array()) {
   /**
    * @see https://developers.podio.com/doc/applications/add-new-app-22351
    */
-  public static function create($attributes = array()) {
-    return self::member(Podio::post("/app/", $attributes));
+  public static function create($attributes = array(), $silent = false) {
+    return self::member(Podio::post(Podio::url_with_options("/app/", array('silent' => $silent)), $attributes));
   }
 
   /**
    * @see https://developers.podio.com/doc/applications/update-app-22352
    */
-  public static function update($app_id, $attributes = array()) {
-    return Podio::put("/app/{$app_id}", $attributes);
+  public static function update($app_id, $attributes = array(), $silent = false) {
+    return Podio::put(Podio::url_with_options("/app/{$app_id}", array('silent' => $silent)), $attributes);
   }
 
   /**
    * @see https://developers.podio.com/doc/applications/delete-app-43693
    */
-  public static function delete($app_id) {
-    return Podio::delete("/app/{$app_id}");
+  public static function delete($app_id, $silent = false) {
+    return Podio::delete(Podio::url_with_options("/app/{$app_id}", array('silent' => $silent)));
   }
 
   /**

models/PodioComment.php

@@ -7,7 +7,7 @@ public function __construct($attributes = array()) {
     $this->property('comment_id', 'integer', array('id' => true));
     $this->property('value', 'string');
     $this->property('rich_value', 'string');
-    $this->property('external_id', 'integer');
+    $this->property('external_id', 'string');
     $this->property('space_id', 'integer');
     $this->property('created_on', 'datetime');
     $this->property('like_count', 'integer');

models/field/PodioTagItemField.php

@@ -8,7 +8,17 @@ class PodioTagItemField extends PodioItemField
 
   public function api_friendly_values()
   {
-    return $this->values !== null ? $this->values : null;
+    return $this->values ? $this->values : array();
+  }
+
+  public function humanized_value()
+  {
+    if (!$this->values) {
+      return '';
+    }
+    return join(';', array_map(function ($value) {
+      return $value['value'];
+    }, $this->values));
   }
 
 }

tests/PodioCalculationItemFieldTest.php

@@ -11,12 +11,31 @@ public function setup() {
     ));
     $this->empty_values = new PodioCalculationItemField(array('field_id' => 1));
     $this->zero_value = new PodioCalculationItemField(array('__api_values' => true, 'field_id' => 2, 'values' => array(array('value' => '0'))));
+    $this->date_value = new PodioCalculationItemField(array(
+      '__api_values' => true, 
+      'field_id' => 3, 
+      'values' => array(array(
+        'start' => '2016-11-11 00:00:00',
+        'start_date_utc' => '2016-11-11',
+        'start_time_utc' => '00:00:00',
+        'start_time' => '00:00:00',
+        'start_utc' => '2016-11-11 00:00:00',
+        'start_date' => '2016-11-11'
+      ))));
   }
 
   public function test_can_provide_value() {
     $this->assertNull($this->empty_values->values);
     $this->assertEquals('1234.5600', $this->object->values);
     $this->assertEquals('0', $this->zero_value->values);
+    $this->assertEquals(array(
+      'start' => '2016-11-11 00:00:00',
+      'start_date_utc' => '2016-11-11',
+      'start_time_utc' => '00:00:00',
+      'start_time' => '00:00:00',
+      'start_utc' => '2016-11-11 00:00:00',
+      'start_date' => '2016-11-11'
+    ), $this->date_value->values);
   }
 
   public function test_cannot_modify_value() {
@@ -28,12 +47,16 @@ public function test_can_humanize_value() {
     $this->assertEquals('', $this->empty_values->humanized_value());
     $this->assertEquals('1234.56', $this->object->humanized_value());
     $this->assertEquals('0', $this->zero_value->humanized_value());
+    // cannot humanize value for date ($this->date_value)
   }
 
   public function test_can_convert_to_api_friendly_json() {
     $this->assertEquals('null', $this->empty_values->as_json());
     $this->assertEquals('"1234.5600"', $this->object->as_json());
     $this->assertEquals('"0"', $this->zero_value->as_json());
+    $date_value_json = '{"start":"2016-11-11 00:00:00","start_date_utc":"2016-11-11","start_time_utc":"00:00:00",' .
+      '"start_time":"00:00:00","start_utc":"2016-11-11 00:00:00","start_date":"2016-11-11"}';
+    $this->assertEquals('' . $date_value_json . '', $this->date_value->as_json());
   }
 
 }