Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let Podio handle http errors #212

Merged
merged 5 commits into from
Sep 24, 2021
Merged

Let Podio handle http errors #212

merged 5 commits into from
Sep 24, 2021

Conversation

carlfredrikhero
Copy link
Member

Fixes #211

daniel-sc
daniel-sc approved these changes Sep 23, 2021
View reviewed changes
Copy link
Member

@daniel-sc daniel-sc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect. If you could add an entry to the changelog: even better :)

@carlfredrikhero
Copy link
Member Author

Sure, do you want it to be part of the upcoming 6.1 or do we release it as 6.0.1? How far away is 6.1?

@daniel-sc
Copy link
Member

I'd go for a 6.0.1 - as this is a rather critical bug.

@carlfredrikhero carlfredrikhero merged commit 1182e8a into podio-community:master Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-sc daniel-sc daniel-sc approved these changes

@rafaelmb rafaelmb rafaelmb approved these changes

@dylannadon dylannadon dylannadon approved these changes

@bajarang-agarwal bajarang-agarwal Awaiting requested review from bajarang-agarwal

@timosillander timosillander Awaiting requested review from timosillander

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Using an expired token throws PodioConnectionError without attempt to refresh token
4 participants
@carlfredrikhero @daniel-sc @rafaelmb @dylannadon