Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove undefined index for set_value(falsy value) #84

Merged
merged 1 commit into from Jul 1, 2015
Merged

Remove undefined index for set_value(falsy value) #84

merged 1 commit into from Jul 1, 2015

Commits on Apr 15, 2015

  1. Remove undefined index for set_value(falsy value) 

    If set_value is called with a falsy value (false, 0, null etc), $this->values gets an empty array.

But the __get assumes that there is at least one value (return $attribute[0] on line 276). This results in an "undefined index" error.

Adding a check for empty array fixes this.
    @carlfredrikhero
    carlfredrikhero committed Apr 15, 2015
    Configuration menu
    Copy the full SHA
    b060f67 View commit details
    Browse the repository at this point in the history