Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't mention two people with the same name #50

Closed
geowa4 opened this issue Aug 27, 2012 · 10 comments
Closed

Can't mention two people with the same name #50

geowa4 opened this issue Aug 27, 2012 · 10 comments

Comments

@geowa4
Copy link

geowa4 commented Aug 27, 2012

Mentioning someone with the same name as someone who was already tagged, replaces the original tag with the new mention.

@auchenberg
Copy link
Contributor

This is actually on purpose. This is the reason why similar values should be filtered out of the autocompleter data.

Conceptually I don't think it doesn't make sense to mention the same person twice.

@geowa4
Copy link
Author

geowa4 commented Aug 28, 2012

I don't really see how this is related to mentioning the same person twice. I completely agree with the restriction here. However, if I know two people named John Smith, I should be able to mention them both.

Internally, the mention syntax of the originally tagged John Smith is replaced with the mention syntax of the most recently mentioned John Smith.

@SteelBRS
Copy link

SteelBRS commented Sep 4, 2012

Any way to enable mentioning the same multiple times?

@geowa4
Copy link
Author

geowa4 commented Sep 4, 2012

@TorbenVesterager: Yeah, it's a fairly simple code change. Most of it isprobably in the updateValues function. However, I agree with @auchenberg on that. It doesn't make sense. Even Facebook doesn't let you do that.

@SteelBRS
Copy link

SteelBRS commented Sep 4, 2012

I actually use it for a referencing solution thing, where it might make sense to reference the same field multiple times

@einarhuseby
Copy link

Same if you mention someone who's name is a subset of a previous mention, e.g. you first mention "John Smith" then mention "John"

@chakhedik
Copy link

I'm also interested to know how to make another person with the same name which already tagged available in autocomplete....

@aqibgulrez
Copy link

there can be 2 users with same names. John[id=1] and John[id=2]. how to tag both ones. currenlty it removes both if we select 1?

@juanvillegas
Copy link
Contributor

I think this pull should fix it: #136

@djhvscf
Copy link
Contributor

djhvscf commented Jul 6, 2015

Yes, you're right.. Thanks @juanvillegas

@djhvscf djhvscf closed this as completed Jul 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants