This repository has been archived by the owner on Feb 1, 2021. It is now read-only.
Add hook parameter in ItemAPI.java #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
holm
pushed a commit
that referenced
this pull request
Dec 12, 2013
Add hook parameter in ItemAPI.java
|
Looks good, thanks for the PR |
|
Wow thank you for the speedy reply and merge! When I tested this locally, I could still see webhooks being executed even when this hook param is set to false. Is is correct to assume that it worked properly for you? |
|
I will take a look later today to see if I can figure out why, it should just work. |
|
Thanks again Christian. I'll be doing more testing on my end as well... So does anyone call you Sherlock? |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello Podio support!
In the API documentation for Items, I can see that some methods(addItem, deleteItem, updateItem) have the parameters silent and hook. In podio-java I only see the silent parameter and so I have added the hook param, but when testing this change locally I can see that the webhooks are still being executed even when setting the new hook parameter to false. Can you please review the changes as I am uncertain why it didn't work?
Thank you in advance and all the best,
Sarah