-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
chore: patch out validation of extensionId
We provide it in manifest.json to pass manifest v3 validation, and that is at odds with passing it as a CLI to web-ext.
- Loading branch information
Showing
3 changed files
with
214 additions
and
0 deletions.
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
diff --git a/node_modules/semantic-release-firefox-add-on/src/constants.js b/node_modules/semantic-release-firefox-add-on/src/constants.js | ||
index c5dea36..2e34ade 100644 | ||
--- a/node_modules/semantic-release-firefox-add-on/src/constants.js | ||
+++ b/node_modules/semantic-release-firefox-add-on/src/constants.js | ||
@@ -11,8 +11,6 @@ const defaultOptions = { | ||
} | ||
|
||
const requiredOptions = { | ||
- extensionId: | ||
- 'Omitting this would create a new extension instead of a new version.', | ||
targetXpi: | ||
'Omitting this would leave the xpi file unnamed when it is returned from mozilla.', | ||
} | ||
diff --git a/node_modules/semantic-release-firefox-add-on/src/publish.js b/node_modules/semantic-release-firefox-add-on/src/publish.js | ||
index ad0f63d..6c3ce35 100644 | ||
--- a/node_modules/semantic-release-firefox-add-on/src/publish.js | ||
+++ b/node_modules/semantic-release-firefox-add-on/src/publish.js | ||
@@ -16,7 +16,6 @@ const publish = async options => { | ||
// the console which will lead to the validation page which should contain | ||
// detailed reasons why the extension was rejected | ||
const { | ||
- extensionId, | ||
artifactsDir, | ||
channel, | ||
sourceDir, | ||
@@ -46,7 +45,6 @@ const publish = async options => { | ||
apiSecret: FIREFOX_SECRET_KEY, | ||
artifactsDir, | ||
channel, | ||
- id: extensionId, | ||
sourceDir, | ||
}, | ||
{ signAddon }, |