change select menus with Autocomplete component #1475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Tests will run for this PR. Once they succeed it can be merged. |
igoychev
requested changes
Jul 10, 2023
Comment on lines
+22
to
+23
| <Autocomplete | ||
| value={beneficiary} |
There was a problem hiding this comment.
please add size="small" here to preserve the original for more condensed size of the dropdown
| } | ||
| isOptionEqualToValue={(option, value) => | ||
| option.person | ||
| ? option.person.firstName === value?.person?.firstName |
There was a problem hiding this comment.
is it enough to compare only the first name?
(not sure what is the expected behaviour just by reading the code)
| import { useTranslation } from 'react-i18next' | ||
| import { useBeneficiariesList } from 'service/beneficiary' | ||
|
|
||
| export default function BeneficiarySelect({ name = 'beneficiaryId' }) { | ||
| const { t } = useTranslation() | ||
| const { data } = useBeneficiariesList() | ||
| const [field, meta] = useField(name) | ||
| const [field, meta, { setValue }] = useField(name) |
There was a problem hiding this comment.
the linter will complain that 'field' is unused now. to fix it just skip the field like this:
const [, meta, { setValue }] = useField(name)
igoychev
approved these changes
Jul 11, 2023
github-actions
bot
removed
the
run tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1465