Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inject hotjar script #1487

Merged
merged 2 commits into from
Jul 17, 2023
Merged

Inject hotjar script #1487

merged 2 commits into from
Jul 17, 2023

Conversation

sashko9807
Copy link
Member

@sashko9807 sashko9807 commented Jul 14, 2023 •
edited
Loading

Injects HotJar library needed to generate heatmap

Steps to test

  1. Go to index or /campaigns page and Load DevTools(Right click -> Inspect or F12). To check if it loads on specific campaign, edit the condition inside ShouldIncludeHotJar to include slug from local enviroment.
  2. Check if the <head> element includes the hotjar script.

@github-actions
Copy link

github-actions bot commented Jul 14, 2023 •
edited
Loading

✅ Tests will run for this PR. Once they succeed it can be merged.

igoychev
igoychev approved these changes Jul 17, 2023
View reviewed changes
Copy link
Contributor

@igoychev igoychev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

neat and tidy!

@igoychev igoychev added the run tests Allows running the tests workflows for forked repos label Jul 17, 2023
@github-actions github-actions bot removed the run tests Allows running the tests workflows for forked repos label Jul 17, 2023
igoychev
igoychev requested changes Jul 17, 2023
View reviewed changes
Copy link
Contributor

@igoychev igoychev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops the build is failing

@sashko9807
HotJar.tsx: Extend Window interface to include hj property
5e99c32 
By default Window interface has no type for the hj property.

Test:
Run yarn build
Builds successfully
@ani-kalpachka ani-kalpachka added the run tests Allows running the tests workflows for forked repos label Jul 17, 2023
@github-actions github-actions bot removed the run tests Allows running the tests workflows for forked repos label Jul 17, 2023
@igoychev igoychev merged commit a70c1e4 into podkrepi-bg:master Jul 17, 2023
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igoychev igoychev igoychev approved these changes

@ani-kalpachka ani-kalpachka ani-kalpachka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sashko9807 @igoychev @ani-kalpachka