Crytic properties #141
Merged
Crytic properties #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Change state variables from public to private - Invariant test do not extend from STETHVault - Change STETHVault to STETHVaultHarness
Takes into account accepted rounding error on tested property
…ontracts into crytic-properties
|
Ready for review @Robsonsjre |
|
@Robsonsjre added remote-echidna setup |
Robsonsjre
approved these changes
Mar 13, 2023
|
Approved. Although I didn't understand where you are using EC2 and S3 secret keys in the script |
|
It's on another repo |
Testing new invariant
aviggiano
force-pushed
the
crytic-properties
branch
from
c6da278
to
66c4536
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Notes
The out-of-the-box properties from
CryticERC4626PropertyTestscorrectly identify the rounding issues #47 and #48 also found on OpenZeppelin's first audit. Simply reverting the changes of PR #46 will make the fuzzy tests fail in under 10,000 iterations.