Issue with Pods GF add-on hooks for updating form entry

[saifsultanc]

Issue Overview

The issue received from a customer with PODS Workflow Step on Gravity Flow. PHP Fatal Error on L992 of class Pods_GF_Addon here.

Expected Behavior

It should process the PODS without any error.

Current Behavior

PHP Fatal Error reported:
PHP Fatal error: Uncaught Error: Class 'GFEntryDetail' not found in /.../public/wp-content/plugins/pods-gravity-forms/includes/Pods_GF_Addon.php:992

Possible Solution

Check with GFCommon::is_entry_detail() to ensure its on the correct page before calling that method, or use gform_pre_entry_detail action hook before calling the method.

Steps to Reproduce (for bugs)

1. Apply settings for the test pod: https://s.gflo.io/OAugnpWv
2. Create a form and set the Pod Feed Settings: https://s.gflo.io/geu4A6z8
3. With Gravity Flow, create a workflow for the form with a User Input Step followed by a PODS Workflow Step.
4. Process a form entry. Then from the workflow inbox, process the User Input Step. The PHP Fatal Error will be reported. Here's how the issue replicates: https://s.gflo.io/xQun6GlO

Form Upload

``` {"0":{"title":"16382","description":"","labelPlacement":"top_label","descriptionPlacement":"below","button":{"type":"text","text":"Submit","imageUrl":""},"fields":[{"type":"name","id":1,"label":"Name","adminLabel":"","isRequired":false,"size":"medium","errorMessage":"","visibility":"visible","nameFormat":"advanced","inputs":[{"id":"1.2","label":"Prefix","name":"","choices":[{"text":"Dr.","value":"Dr."},{"text":"Miss","value":"Miss"},{"text":"Mr.","value":"Mr."},{"text":"Mrs.","value":"Mrs."},{"text":"Ms.","value":"Ms."},{"text":"Prof.","value":"Prof."},{"text":"Rev.","value":"Rev."}],"isHidden":true,"inputType":"radio"},{"id":"1.3","label":"First","name":""},{"id":"1.4","label":"Middle","name":"","isHidden":true},{"id":"1.6","label":"Last","name":""},{"id":"1.8","label":"Suffix","name":"","isHidden":true}],"formId":31,"description":"","allowsPrepopulate":false,"inputMask":false,"inputMaskValue":"","inputMaskIsCustom":"","maxLength":"","inputType":"","labelPlacement":"","descriptionPlacement":"","subLabelPlacement":"","placeholder":"","cssClass":"","inputName":"","noDuplicates":false,"defaultValue":"","choices":"","conditionalLogic":"","productField":"","fields":""},{"type":"email","id":2,"label":"Email","adminLabel":"","isRequired":false,"size":"medium","errorMessage":"","visibility":"visible","inputs":null,"formId":31,"description":"","allowsPrepopulate":false,"inputMask":false,"inputMaskValue":"","inputMaskIsCustom":"","maxLength":"","inputType":"","labelPlacement":"","descriptionPlacement":"","subLabelPlacement":"","placeholder":"","cssClass":"","inputName":"","noDuplicates":false,"defaultValue":"","choices":"","conditionalLogic":"","productField":"","emailConfirmEnabled":"","fields":""}],"version":"2.4.22","id":31,"nextFieldId":3,"useCurrentUserAsAuthor":true,"postContentTemplateEnabled":false,"postTitleTemplateEnabled":false,"postTitleTemplate":"","postContentTemplate":"","lastPageButton":null,"pagination":null,"firstPageCssClass":null,"confirmations":[{"id":"602e7dc27aace","name":"Default Confirmation","isDefault":true,"type":"message","message":"Thanks for contacting us! We will get in touch with you shortly.","url":"","pageId":"","queryString":""}],"notifications":[{"id":"602e7dc27a643","isActive":true,"to":"{admin_email}","name":"Admin Notification","event":"form_submission","toType":"email","subject":"New submission from {form_title}","message":"{all_fields}"}],"feeds":{"gravityflow":[{"id":"124","form_id":"31","is_active":"1","feed_order":"0","meta":{"step_name":"Start","description":"","step_type":"workflow_start","feed_condition_conditional_logic":"0","feed_condition_conditional_logic_object":[],"scheduled":"0","schedule_type":"delay","schedule_date":"","schedule_delay_offset":"","schedule_delay_unit":"hours","schedule_date_field_before_after":"after","schedule_date_field_offset":"0","schedule_date_field_offset_unit":"hours","instructionsEnable":"0","instructionsValue":"","display_fields_mode":"all_fields","destination_complete":"next"},"addon_slug":"gravityflow","event_type":null},{"id":"126","form_id":"31","is_active":"1","feed_order":"0","meta":{"step_name":"UI","description":"","step_type":"user_input","step_highlight":"0","step_highlight_type":"color","step_highlight_color":"#dd3333","feed_condition_conditional_logic":"0","feed_condition_conditional_logic_object":[],"scheduled":"0","schedule_type":"delay","schedule_date":"","schedule_delay_offset":"","schedule_delay_unit":"hours","schedule_date_field_offset":"0","schedule_date_field_offset_unit":"hours","schedule_date_field_before_after":"after","type":"select","assignees":["user_id|2"],"editable_fields":["1"],"routing":"","assignee_policy":"all","highlight_editable_fields_enabled":"0","highlight_editable_fields_class":"green-triangle","instructionsEnable":"0","instructionsValue":"","display_fields_mode":"all_fields","default_status":"hidden","note_mode":"not_required","assignee_notification_enabled":"0","assignee_notification_from_name":"","assignee_notification_from_email":"{admin_email}","assignee_notification_reply_to":"","assignee_notification_cc":"","assignee_notification_bcc":"","assignee_notification_subject":"","assignee_notification_message":"A new entry requires your input.","assignee_notification_disable_autoformat":"0","resend_assignee_emailEnable":"0","resend_assignee_emailValue":"7","resend_assignee_email_repeatEnable":"0","resend_assignee_email_repeatValue":"3","in_progress_notification_enabled":"0","in_progress_notification_type":"select","in_progress_notification_routing":[{"assignee":"user_id|1","fieldId":"0","operator":"is","value":"","type":""}],"in_progress_notification_from_name":"","in_progress_notification_from_email":"{admin_email}","in_progress_notification_reply_to":"","in_progress_notification_cc":"","in_progress_notification_bcc":"","in_progress_notification_subject":"","in_progress_notification_message":"Entry {entry_id} has been updated and remains in progress.","in_progress_notification_disable_autoformat":"0","complete_notification_enabled":"0","complete_notification_type":"select","complete_notification_routing":[{"assignee":"user_id|1","fieldId":"0","operator":"is","value":"","type":""}],"complete_notification_from_name":"","complete_notification_from_email":"{admin_email}","complete_notification_reply_to":"","complete_notification_cc":"","complete_notification_bcc":"","complete_notification_subject":"","complete_notification_message":"Entry {entry_id} has been updated completing the step.","complete_notification_disable_autoformat":"0","confirmation_messageEnable":"0","confirmation_messageValue":"Thank you.","due_date":"0","due_date_type":"delay","due_date_date":"","due_date_delay_offset":"","due_date_delay_unit":"hours","due_date_date_field_offset":"0","due_date_date_field_offset_unit":"hours","due_date_date_field_before_after":"after","due_date_highlight_type":"color","due_date_highlight_color":"#dd3333","expiration":"0","expiration_type":"delay","expiration_date":"","expiration_delay_offset":"","expiration_delay_unit":"hours","expiration_date_field_offset":"0","expiration_date_field_offset_unit":"hours","expiration_date_field_before_after":"after","status_expiration":"complete","destination_expired":"next","destination_complete":"next"},"addon_slug":"gravityflow","event_type":null},{"id":"127","form_id":"31","is_active":"1","feed_order":"0","meta":{"step_name":"Trigger pods","description":"","step_type":"pods","step_highlight":"0","step_highlight_type":"color","step_highlight_color":"#dd3333","feed_condition_conditional_logic":"0","feed_condition_conditional_logic_object":[],"scheduled":"0","schedule_type":"delay","schedule_date":"","schedule_delay_offset":"","schedule_delay_unit":"hours","schedule_date_field_offset":"0","schedule_date_field_offset_unit":"hours","schedule_date_field_before_after":"after","feed_123":"1","destination_complete":"next"},"addon_slug":"gravityflow","event_type":null},{"id":"125","form_id":"31","is_active":"1","feed_order":"0","meta":{"step_name":"Complete","description":"","step_type":"workflow_complete","feed_condition_conditional_logic":"0","scheduled":"0"},"addon_slug":"gravityflow","event_type":null}],"pods-gravity-forms":[{"id":"123","form_id":"31","is_active":"1","feed_order":"0","meta":{"feedName":"Pods Feed 1","pod":"gravityflowtest","pod_fields_gravity_flow_pod":"id","pod_fields_gravity_flow_pod_custom":"","wp_object_fields_post_title":"1.2","wp_object_fields_post_title_custom":"","wp_object_fields_post_content":"1","wp_object_fields_post_content_custom":"","wp_object_fields_post_excerpt":"","wp_object_fields_post_excerpt_custom":"","wp_object_fields_post_author":"","wp_object_fields_post_author_custom":"","wp_object_fields_post_date":"","wp_object_fields_post_date_custom":"","wp_object_fields_post_name":"","wp_object_fields_post_name_custom":"","wp_object_fields_post_modified":"","wp_object_fields_post_modified_custom":"","wp_object_fields_post_parent":"","wp_object_fields_post_parent_custom":"","wp_object_fields_comments":"","wp_object_fields_comments_custom":"","wp_object_fields__thumbnail_id":"","wp_object_fields__thumbnail_id_custom":"","custom_fields":"","update_pod_item":"0","enable_markdown":"0","enable_current_post":"0","enable_prepopulate":"0","delete_entry":"0","feed_condition_conditional_logic":"0","feed_condition_conditional_logic_object":[]},"addon_slug":"pods-gravity-forms","event_type":null}]}},"version":"2.4.22"} ```

Regards,
The Gravity Flow Team
http://gravityflow.io/
GitHub Repo: https://github.com/gravityflow/gravityflow