Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Predefined simple pick objects don't validate values #3631

Open
jamesgol opened this issue Jul 6, 2016 · 4 comments
Open

Predefined simple pick objects don't validate values #3631

jamesgol opened this issue Jul 6, 2016 · 4 comments

Comments

@jamesgol
Copy link
Contributor

jamesgol commented Jul 6, 2016

While adding some more generic tests to the testing suite, one of the test I added uncovered the fact that by code I can set the value of one of the predefined lists (I tested with 'us_state') and it accepts the value without complaining.

If you use a 'custom-simple' type pick object invalid values are just removed. For these types the removal happens in PodsAPI->save_pod_item().

When I get a chance I'll look into fixing this, but I think the best place to do it is in the PodsField_Pick->validate() function

@quasel
Copy link
Member

quasel commented Aug 31, 2018

did you take look? is this still an issue? bet you far faster then me taking a look!

@quasel quasel added Status: Need User Feedback Waiting on feedback from user who reported issue Type: Bug Status: Need Reproduction Issue must be reproduced before coding can begin labels Aug 31, 2018
@jamesgol
Copy link
Contributor Author

Never got around to fixing it but I'm sure it's still an issue

@quasel
Copy link
Member

quasel commented Aug 31, 2018

are you planning to still do it? 🥇

@quasel quasel self-assigned this Aug 31, 2018
@jamesgol
Copy link
Contributor Author

jamesgol commented Sep 1, 2018

It's on my todo list

@quasel quasel assigned jamesgol and unassigned quasel Sep 2, 2018
@quasel quasel added Status: Reproduced and removed Status: Need Reproduction Issue must be reproduced before coding can begin Status: Need User Feedback Waiting on feedback from user who reported issue labels Sep 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants