Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial GeoJSON support #693

Merged
merged 2 commits into from
Nov 18, 2023
Merged

Initial GeoJSON support #693

merged 2 commits into from
Nov 18, 2023

Conversation

gibbz00
Copy link
Contributor

@gibbz00 gibbz00 commented Nov 17, 2023

Implements Type, ParseFromJson and ToJson on GeoJSON geometries by integrating with geo-types and geojson.

Partially solves: #585

I'm a bit unsure if the dependencies have been correctly added in Cargo.toml, given that I was unable to find any mention of the other features there (uuid, chorno, url etc.).

The only missing geometry I haven't yet implemented is GeometryCollection. Perhaps an issue could be opened to implement it, but I could also (if wished for) add it here.

gibbz00 added 2 commits November 17, 2023 16:10
Implements `Type` on GeoJSON geometries by integrating with `geo-types`
and `geojson`. The only missing geometry is [`GeometryCollection`]
(https://datatracker.ietf.org/doc/html/rfc7946#appendix-A.7).
@sunli829 sunli829 merged commit c555d37 into poem-web:master Nov 18, 2023
7 checks passed
@gibbz00 gibbz00 deleted the geo branch November 18, 2023 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants