Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

24h clock styling #15

Closed
PrtmPhlp opened this issue Sep 3, 2022 · 3 comments
Closed

24h clock styling #15

PrtmPhlp opened this issue Sep 3, 2022 · 3 comments
Labels
enhancement New feature or request

Comments

@PrtmPhlp
Copy link

PrtmPhlp commented Sep 3, 2022

I'm from Germany and here the time is 24h based. Would love a future Feature, where you can toggle between the 12 and 24 hour system. (Maybe directly in the "set or reset timezone" menu)

@poetaman
Copy link
Owner

poetaman commented Sep 3, 2022

That would be a good feature to have, will definitely add that, perhaps coming week if I get time.

@poetaman poetaman added the enhancement New feature or request label Sep 3, 2022
@poetaman
Copy link
Owner

poetaman commented Sep 21, 2022

@PrtmPhlp @cjk I have pushed the change in main branch. Pull and run install.sh again if you installed using method 2) or just copy paste and run the simple installer again (it automatically pulls main branch and merges) if you used install method 1). https://github.com/reportaman/arttime#installation

There are 2 changes in UI:

  1. A CLI new option --hours can be provided while invoking arttime with value 24 or 12 (default)*
  2. A new keybinding f is added to toggle between 12 and 24 hour formats. Pressing f quickly toggles all times shown by arttime to one of the formats.

* I would recommend to set alias: alias arttime="arttime --hours 24" for those who want 24 hours by default. In future arttime might parse user's locale to find whether they want 12 hour or 24 hour format if there is a compelling reason...

@poetaman poetaman pinned this issue Sep 22, 2022
@PrtmPhlp
Copy link
Author

Thank you so much. Works great.

@poetaman poetaman unpinned this issue Sep 30, 2022
@poetaman poetaman pinned this issue Oct 7, 2022
poetaman added a commit that referenced this issue Dec 5, 2022
… user can start the arttime with an option --hours 12|24 to start with 12/24 hour format. 2) user can press f to toggle between 12 and 24 hour formats. All the times displayed in the application switch the format together, from main screen to goal's in information page, to desktop notifications. This fixes #15.
@poetaman poetaman unpinned this issue Nov 17, 2023
poetaman added a commit that referenced this issue Dec 4, 2023
… user can start the arttime with an option --hours 12|24 to start with 12/24 hour format. 2) user can press f to toggle between 12 and 24 hour formats. All the times displayed in the application switch the format together, from main screen to goal's in information page, to desktop notifications. This fixes #15.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants