Auto update dummy config #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| updateDummyConfig: function() { | ||
| var name = this.project.pkg.name; | ||
| var search = " if (environment === 'production') {"; | ||
| var replace = " if (environment === 'production') {\n ENV.locationType = 'hash';\n ENV.baseURL = '/" + name + "';"; |
There was a problem hiding this comment.
Line is too long.
Mixed double and single quotes.
knownasilya
force-pushed
the
update-config
branch
from
e9a2c2e
to
fae8f3e
Compare
knownasilya
pushed a commit
that referenced
this pull request
Feb 9, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So previously this addon was supposed to auto update the config, but it never did since the config is in
tests/dummy/config.This change uses the configPath in the package.json to update the correct config.
Not sure if this would require a major bump, since maybe the config was in the base directory before.
See #12