Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/tf dataset adapter #144

Merged
merged 6 commits into from Jan 22, 2021
Merged

Feature/tf dataset adapter #144

merged 6 commits into from Jan 22, 2021

Conversation

charlielito
Copy link
Collaborator

Adapter for handling tensorflow's tf.data.Dataset

@codecov-io
Copy link

codecov-io commented Jan 17, 2021

Codecov Report

Merging #144 (338217f) into master (1a2fcc9) will increase coverage by 0.26%.
The diff coverage is 92.10%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #144      +/-   ##
==========================================
+ Coverage   78.97%   79.24%   +0.26%     
==========================================
  Files         112      114       +2     
  Lines        5475     5589     +114     
==========================================
+ Hits         4324     4429     +105     
- Misses       1151     1160       +9     
Impacted Files Coverage Δ
elegy/data/data_handler.py 72.41% <66.66%> (-0.43%) ⬇️
elegy/data/tf_dataset_adapter.py 86.00% <86.00%> (ø)
elegy/data/tf_dataset_adapter_test.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a2fcc9...338217f. Read the comment docs.

@cgarciae
Copy link
Collaborator

cgarciae commented Jan 22, 2021

@charlielito lets merge this before #139
Edit: On second thought, lets wait for #139 because it easier to fix the conflicts from this smaller PR than from that one.

@charlielito charlielito merged commit 124683f into master Jan 22, 2021
@charlielito charlielito deleted the feature/tf_dataset_adapter branch January 22, 2021 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants