Fixes to get the Bot working and then some more... #26
Conversation
…h warnings if the command/listener takes more than one argument but only some are supplied.
|
Good job. I'll take a look at commit when I'll have time and let you know how is it. For merging, we'll have to wait for @pogosheep. |
…ng too "trustworthy" and allowing commands to get the nick/username/hostname of the sender. An attempt to remove colons from the beginning of fields that don't need them such that Listeners don't have to manually remove them. Also implemented a serialise and remember (un-serialise) structure so that Commands and Listeners may save their state and recall this state later. This needs further expansion so that Expansion ideas: Master recognition system such that serialise/remember/(quit/timeout/restart) can't be abused. Command/Listener enable/disable system.
|
I've just pushed up more adds some functionality to the bot that it didn't have as well as fixing an issue mentioned here: #16 Also added is serialisation and remembering (un-serialisation) which for now is a manual process (initiated by !serialise and !remember assuming those plug-ins are enabled, hence the new config. file). One thing I noticed is that if the bot is messaged personally it responds to itself rather than to the user who messaged them. |
|
Hey, could you use spaces for indentation instead of tabs. Code looks a bit hard to read if we mix that two together. Could you explain a bit more about this two new commands? |
…ages rather than sending the message back to itself.
|
Sorry, I would've though github would convert tabs to spaces automatically. (I'm a bit new to all this) The serialisation function serves as a way for Commands and Listeners to store data to a file, or database on demand so that it may be recalled later into the memory of the bot. If you write a new Command or Listener, you only need to implement serialise and remember to have this store/load functionality. Probably would be wise for the Bot class to have a field which is set by the config. file for a directory to store files into. (Also I fixed the bot messaging itself instead of the user who messaged it which I mentioned previously). |
|
@ElvenSpellmaker i just did a quick review and it looks great. It would be awesome now that we would have a command or listener to use this. |
…s for me as I don't know how to set-up a channel with a password. I need to update the README soon as well seeing as a *lot* has been changed since I forked.
Instead of just a plain array of channels, like "#PHPTest" you now have a hash: "#PHPTest => '', #cs => 'foobarbaz'" PHPTest is a channel without a password and cs is a channel with the password foobarbaz.
Consider to alleviate potential JOIN spam, joining all JOIN messages into one join message: e.g. JOIN #PHPTest JOIN #cs foobarbaz | V JOIN #PHPtest,#cs ,foobarbaz
It also switches the NICK and USER commands around as you are *meant* to send NICK before USER.
|
I have done a few more commits today to try and make the bot handle passwords for both servers and channels, as described in these reports: If people can validate they work I'd be very grateful! I haven't implemented nickname passwords yet. (Such as messaging nickserv), I may attempt this later. |
Hopefully this time it works...
…ore generic one. Check for "End of /MOTD command" instead of "Welcome" as not every MOTD has Welcome in it!
|
(I have no idea how I have closed the pull request twice...) Update: Changed a naïve way of looking if you are welcome, I assume if you can see the MOTD then you are welcome, probably isn't always the case, but it's better than looking for "Welcome". |
|
@matejvelikonja Do you have write access to Pogosheep's repo? If so, can't you merge my changes? |
|
yes, I have it now. @pogosheep doesn't have enough time to do this, so he gave me permissions. will merge this as soon as I test it and figure out how we will proceed with development. lot's of developers started to contribute, and we will have to make some rules about that. like start writing tests, code standards etc. we have to write maintainable and well tested code. i also have to set up irc channel, so we can stay in touch easier. |
|
@ElvenSpellmaker can you merge current version of pogosheep code to your one? otherwise i cant accept PR. |
|
I will when I get back home in a couple of hours. |
|
I will also hopefully upload the few plugins I have written and will update the readme. |
|
Also where is the IRC channel so I can join please? |
|
look at the config file :) |
Merging with pogo's code. Conflicts: Classes/Library/IRC/Bot.php
… bit anyway). Changed a few more things, allows commands to send to private messages and other channels, plus a few more bugfixes.
Added several methods to bot.php: getListeners(), getListener() and getCommand() Change-Id: I1179281401cdaa2a4dcc50e647ec8462219bd265
Added common code to a super class
classes' method Change-Id: I6f934eb4499fa5ba3710f64e3eb1b36bfcf64d25
removed say() method in Listener Base
Change-Id: I5e96b72cc8ac3a714ab728c1c362963000919d79
code refactoring
…ngPogosCode Merging Hosh's changes. Conflicts: Classes/Library/IRC/Base.php Classes/Library/IRC/Bot.php
… the process so I've merged here. A few other things too. Note: The new structure still needs some more work, Commands and Listeners now have far too many ways of accessing the same information.
|
Seeing as this has many, many merge conflicts and is horrendously old I will close this. I am writing a new version of all these changes over on my fork if anyone would like to check that out. |
I forked your code and tried to run the bot but it complained about passing arguments to commands/listeners that didn't have constructors, so I have made a fix for it which attempts to use arguments and if that fails then it tries to construct without arguments.
If the config. file has arguments but the command/listener doesn't accept them then it will warn the user that the command doesn't accept the supplied arguments.
I also fixed the keywors mistake to keywords because it failed to start due to it being misspelt.
I then noticed that FutileFreedom also fixed the second bug but you haven't committed his pull request yet (I cloned yours and it still had the error), found here: #25
Thanks. =)