Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add reusable clients #74

Merged
merged 8 commits into from
Feb 9, 2024
Merged

Feature/add reusable clients #74

merged 8 commits into from
Feb 9, 2024

Conversation

pogzyb
Copy link
Owner

@pogzyb pogzyb commented Feb 9, 2024

  • Add reusable clients DomainClient, NumberClient, and ASNClient
  • Consolidate exported functions into single entrypoints: asyncwhois.rdap, asyncwhois.whois
  • Change the return type from exported functions from <Domain>Lookup to tuple of query and parsed dict
  • Increase the BLOCKSIZE to cut down on round trips to the server
  • Remove support for python 3.7 and python 3.8

A new Client parent class with child classes - DomainClient, NumberClient, and ASNClient - that better decouple the functionality of the query and parser classes but implement both under the Client base class.
Copy link

codecov bot commented Feb 9, 2024

Codecov Report

Attention: 196 lines in your changes are missing coverage. Please review.

Comparison is base (c6ee77a) 85.83% compared to head (ae38157) 85.05%.

Files Patch % Lines
asyncwhois/__init__.py 31.53% 89 Missing ⚠️
asyncwhois/client.py 39.56% 84 Missing ⚠️
asyncwhois/query.py 71.64% 19 Missing ⚠️
asyncwhois/parse_rir.py 55.55% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #74      +/-   ##
==========================================
- Coverage   85.83%   85.05%   -0.79%     
==========================================
  Files           8        8              
  Lines        2959     2990      +31     
==========================================
+ Hits         2540     2543       +3     
- Misses        419      447      +28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pogzyb pogzyb force-pushed the feature/add-reusable-clients branch from c2798d3 to 0ac7cca Compare February 9, 2024 01:40
@pogzyb pogzyb force-pushed the feature/add-reusable-clients branch from a552441 to 7680c6d Compare February 9, 2024 12:57
@pogzyb pogzyb marked this pull request as ready for review February 9, 2024 18:01
@pogzyb pogzyb force-pushed the feature/add-reusable-clients branch from 0771b0b to ae38157 Compare February 9, 2024 18:28
@pogzyb pogzyb self-assigned this Feb 9, 2024
@pogzyb pogzyb merged commit e65b443 into main Feb 9, 2024
24 of 26 checks passed
@pogzyb pogzyb deleted the feature/add-reusable-clients branch February 9, 2024 18:33
@pogzyb pogzyb mentioned this pull request Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant