Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix checks for ip objects #76

Merged
merged 1 commit into from
Feb 13, 2024
Merged

Fix checks for ip objects #76

merged 1 commit into from
Feb 13, 2024

Conversation

pogzyb
Copy link
Owner

@pogzyb pogzyb commented Feb 11, 2024

Lazy bug - Fix check for ipaddress.IPv4address in exported functions.

Fix check for `ipaddress.IPv4address`
Copy link

codecov bot commented Feb 11, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (a58a8c8) 85.05% compared to head (921ab9e) 85.05%.

Files Patch % Lines
asyncwhois/__init__.py 50.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #76   +/-   ##
=======================================
  Coverage   85.05%   85.05%           
=======================================
  Files           8        8           
  Lines        2990     2990           
=======================================
  Hits         2543     2543           
  Misses        447      447           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pogzyb pogzyb merged commit 1100d4d into main Feb 13, 2024
26 of 28 checks passed
@pogzyb pogzyb deleted the fix-isinstance-checks branch February 13, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant