FIX calling Node[Un]PrepareResources #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 8, 2022
Closed
pohly
force-pushed
the
dynamic-resource-allocation
branch
from
1f00794
to
ca95a8a
Compare
|
If you rebase on top of 7119d09 then I can manually replace your old commits with the new ones. |
If resource is not found in the DRA manager cache Kubelet should not run a container. This should be considered as fatal error because CDI injection can't happen without this.
- added pod referencing external resource claim - used ubuntu images for pod-external and pod-inline - run commands showing device nodes, mounts and env vars - set pod restart policy to Never - renamed shared-resource-claim.yaml -> pod-shared.yaml Co-authored-by: Patrick Ohly <patrick.ohly@intel.com>
bart0sh
force-pushed
the
PR005-pohly-dynamic-resource-allocation
branch
from
801c04b
to
9724ac0
Compare
|
@pohly done, PTAL |
|
Note that I am not really doing any deep code review. I'm just merging your commits when the described change makes sense. |
|
yep, understood. I hope @klueska will review Kubelet changes at some point. I'm still going to at least implement checkpointing and cover the code with unit tests before that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reimplemented a logic of calling Node[Un]PrepareResources APIs such as they're now called once per resource claim.
Previously they're called for every pod that references a resource.
Rebased on top of the recent target branch by request from @pohly
@pohly Thank you for pointing it out to me!