Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre-loading multiple Ads #133

Closed
flaming-toast opened this issue Aug 28, 2022 · 7 comments
Closed

Pre-loading multiple Ads #133

flaming-toast opened this issue Aug 28, 2022 · 7 comments
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed
Milestone

Comments

@flaming-toast
Copy link

Hello! First off, this plugin is amazing and thank you so much for your hard work!

I was integrating this plugin into my game and realized that the plugin cannot seem to handle loading multiple rewarded ads - is this observation correct?

I have two currencies in the game that can be doubled individually if the player watches a rewarded ad. So, I tried to preload two rewarded videos in the game. However, after looking at the plugin source code, it seems that the plugin only shows the most recently loaded one (if load is called multiple times, aRewardedAd variable is reassigned to the last loaded ad)

Is it against some AdMob policy to do this? Or is it just that the current code doesn't support this situation?

@gumaciel
Copy link
Contributor

Thank you for opening this issue.

Actually this is only a feature that we don't have, but will be good if implemented.

I think there's nothing about the AdMob policy.

@flaming-toast
Copy link
Author

Thanks a lot for the response! Yeah, I think a lot of mobile games do preload multiple ads, so I don't think Admob would have a problem with this.

I'm not familiar with Java, but I think it should be simple to implement..? Instead of saving the loaded ad into a variable, maybe we can use a Dictionary/Hash table to map the ad unit names to the RewardedAd instance, and load_rewarded() would just take an extra name as an argument. This issue would also apply to the iOS version as well. What do you think?

@gumaciel
Copy link
Contributor

gumaciel commented Sep 7, 2022

Hi, yes, it should be possible, I've never tried because i was focusing on implement "key features" of AdMob.

It should not be hard, maybe we can use this: https://developers.google.com/admob/android/native/start#loading_ads

I will only be able to work on it after finishing some existing AdMob issues, if possible, try to implement it, maybe these documentations will help:

https://github.com/Poing-Studios/godot-admob-android/wiki/Android-Plugin
https://developers.google.com/admob/android/quick-start

@gumaciel gumaciel changed the title Is pre-loading multiple rewarded ads possible? Pre-loading multiple Ads Sep 7, 2022
@gumaciel gumaciel added the enhancement New feature or request label Sep 7, 2022
@ebudagov
Copy link

ebudagov commented Sep 11, 2022

Hello everyone, just faced the same issue with lack of support for multiple ad units. It would be great to have this feature added

@gumaciel gumaciel added this to the v2.3.0 milestone Oct 3, 2022
@gumaciel gumaciel self-assigned this Oct 3, 2022
@Indieveloper
Copy link

Indieveloper commented Dec 22, 2022

I'm also looking for this feature. It helps for analytics to see how each ad-unit performs.
And it allows the usage of the AdMob ad-unit setting of Frequency Capping for seperate ad-units. The workaround right now is to manually cap it in code itself. And if there's also API calls to obtain info about Frequency Capping, that itself would be nice too.

@gumaciel
Copy link
Contributor

Thank you guys, this Issue will be priority after the Plugin migration for Godot 4.0

@gumaciel gumaciel added the help wanted Extra attention is needed label Dec 26, 2022
@gumaciel gumaciel pinned this issue Dec 26, 2022
@gumaciel gumaciel removed this from the v2.3.0 milestone Jan 19, 2023
@gumaciel
Copy link
Contributor

Closing since it was done on poingstudios/godot-admob-plugin#82 and #167, development is finished but need to test.

Check the future status of iOS here: poingstudios/godot-admob-ios#45

@gumaciel gumaciel unpinned this issue Jun 20, 2023
@gumaciel gumaciel added this to the v3.0.0 milestone Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
Status: Done
Development

No branches or pull requests

4 participants