Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(BREAKING CHANGES) Refactoring MobileAds API to v3.0.0 #45

Closed
21 tasks done
gumaciel opened this issue Jun 20, 2023 · 0 comments · Fixed by #63
Closed
21 tasks done

(BREAKING CHANGES) Refactoring MobileAds API to v3.0.0 #45

gumaciel opened this issue Jun 20, 2023 · 0 comments · Fixed by #63
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@gumaciel
Copy link
Contributor

gumaciel commented Jun 20, 2023

Is your feature request related to a problem? If so, please describe.

This change intends to change many of the plugins in all aspects, in order to make the plugin more dynamic and easy to use, it is necessary almost completely to redo the plugin to meet the use of mediation.

⚠️WARNING⚠️:

What feature or improvement would you like to see?

✅GOALS✅

  • Create an Interface of MobileAds class with Objective-C with the most important methods used on AdMob.
    Example:
void PoingGodotAdMob::initialize() {
    [[GADMobileAds sharedInstance] startWithCompletionHandler:^(GADInitializationStatus *_Nonnull status)
    {
        Dictionary dictionary = [ObjectToGodotDictionary convertGADInitializationStatusToDictionary:status];
        emit_signal("on_initialization_complete", dictionary);
    }];
}

void PoingGodotAdMob::_bind_methods() {
    ADD_SIGNAL(MethodInfo("on_initialization_complete", PropertyInfo(Variant::DICTIONARY, "initialization_status_dictionary")));

    ClassDB::bind_method(D_METHOD("initialize"), &PoingGodotAdMob::initialize);
};

Additional context

No response

@gumaciel gumaciel added the enhancement New feature or request label Jun 20, 2023
@gumaciel gumaciel self-assigned this Jun 20, 2023
@gumaciel gumaciel added this to the v3.0.0 milestone Jun 20, 2023
@gumaciel gumaciel pinned this issue Aug 5, 2023
gumaciel added a commit that referenced this issue Aug 21, 2023
gumaciel added a commit that referenced this issue Aug 21, 2023
gumaciel added a commit that referenced this issue Aug 21, 2023
Usage:

```bash
chmod +x ./scripts/download_godot.sh
./scripts/download_godot.sh 4.1.1
```
gumaciel added a commit that referenced this issue Aug 21, 2023
gumaciel added a commit that referenced this issue Aug 21, 2023
gumaciel added a commit that referenced this issue Aug 23, 2023
gumaciel added a commit that referenced this issue Aug 23, 2023
gumaciel added a commit that referenced this issue Aug 23, 2023
gumaciel added a commit that referenced this issue Aug 23, 2023
gumaciel added a commit that referenced this issue Aug 23, 2023
@gumaciel gumaciel linked a pull request Aug 23, 2023 that will close this issue
gumaciel added a commit that referenced this issue Aug 23, 2023
gumaciel added a commit that referenced this issue Aug 23, 2023
@gumaciel gumaciel unpinned this issue Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant