Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BIP38 (passphrase-encrypted private keys) #8

Closed
wants to merge 2 commits into from

Conversation

scintill
Copy link
Contributor

Includes AES code from the Crypto-JS project, and scrypt code from a NodeJS module (multi-threading by me).

Includes AES code from the Crypto-JS project, and scrypt code from a NodeJS module (multi-threading by me).
@scintill
Copy link
Contributor Author

I've realized maybe I shouldn't have done the Bitcoin.Util.dsha256 changes since they change an upstream bitcoin js lib, which will make it more difficult for you to merge in any updates they make. Let me know if it's a problem.

@ghost ghost assigned pointbiz Jan 21, 2013
@scintill
Copy link
Contributor Author

scintill commented Feb 2, 2013

Support for creating encrypted keys is being finished up (https://bitcointalk.org/index.php?topic=136651), so maybe we should delay until that can be added at the same time.

@pointbiz
Copy link
Owner

scintill great work. I manually merged this with the latest BIP38 Decrypt commit. Thanks!
I modified the UI so that the passphrase box only appears if it's a BIP38 key.

I'll be adding more BIP38 stuff from Zeilaps branch for the Paper Wallets tab.

To run both synchronous and asynchronous tests use these query strings:
?unittests=true&asyncunittests=true

@scintill
Copy link
Contributor Author

Looks great, thanks!

@scintill scintill closed this Apr 16, 2013
@ghost
Copy link

ghost commented Nov 2, 2013

Why wasnt this merged?

@scintill
Copy link
Contributor Author

scintill commented Nov 2, 2013

@Drak: It was essentially merged in a2e09c7 with some other stuff.

@ghost
Copy link

ghost commented Nov 2, 2013

Excellent. Thanks!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants