Fix rack-test to ignore maxlength="", closes teamcapybara#396

pointcom · Jul 8, 2011 · c51a232 · c51a232
1 parent f6c787e
commit c51a232
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/lib/capybara/rack_test/node.rb b/lib/capybara/rack_test/node.rb
@@ -23,7 +23,10 @@ def set(value)
         native.remove_attribute('checked')
       end
     elsif tag_name == 'input'
-      if (type == 'text' || type == 'password') && self[:maxlength]
+      if (type == 'text' || type == 'password') && self[:maxlength] &&
+        !self[:maxlength].empty?
+        # Browser behavior for maxlength="0" is inconsistent, so we stick with
+        # Firefox, allowing no input
         value = value[0...self[:maxlength].to_i]
       end
       native['value'] = value.to_s

diff --git a/lib/capybara/spec/views/form.erb b/lib/capybara/spec/views/form.erb
@@ -50,7 +50,7 @@
 
   <p>
     <label>Street<br/>
-      <input type="text" name="form[street]" value="Sesame street 66"/>
+      <input type="text" maxlength="" name="form[street]" value="Sesame street 66"/>
     </label>
   </p>