Fixes around optionals and partial case key paths #147
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently added code that can flatten optionals in a couple of ways, but because these methods weren't disfavored, they take precedence and can produce case key paths incapable of expressing what you want, like the ability to embed an optional in an case that contains one:
This PR disfavors these overloads to allow you to flatten optionals contextually, but by default will leave them alone.
It also fixes a bug in
PartialCaseKeyPath.callAsFunction
that would prevent non-optionals from being promoted to optionals in cases that expect them:Finally, this PR fixes a bug in which
PartialCaseKeyPath.callAsFunction
was technically available onCaseKeyPath
, which meant you could call it with any value: