Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation clean up #11

Merged
merged 3 commits into from
May 4, 2020

Conversation

gzipChrist
Copy link
Contributor

Fixes some minor documentation issues.

Copy link
Member

@stephencelis stephencelis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time to PR! Just noticed 2 small things...

@@ -43,7 +43,7 @@ extension CasePath where Value == Void {
/// - Parameters:
/// - embed: An enum case initializer.
/// - root: A root enum value.
/// - Returns: Values iff they can be extracted from the given enum case initializer and root enum, otherwise `nil`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is actually okay. We meant it as "if and only if," which even the standard library uses occasionally! 😄

https://github.com/apple/swift/blob/9cdfb0edfcae6fa0baadee5df3690597138b5d5e/stdlib/public/core/ContiguousArrayBuffer.swift#L504

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, TIL! 😄

Sources/ComposableArchitecture/Reducer.swift Outdated Show resolved Hide resolved
Copy link
Member

@mbrandonw mbrandonw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good finds, thanks so much!

Going to ignore the swift-format thing... we're still figuring out the proper GH actions integration.

@stephencelis
Copy link
Member

Gonna merge, thanks!

@stephencelis stephencelis merged commit 7384bd9 into pointfreeco:master May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants