Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow re-entrant actions to be processed #1352

Merged
merged 8 commits into from
Sep 8, 2022
Merged

Allow re-entrant actions to be processed #1352

merged 8 commits into from
Sep 8, 2022

Conversation

stephencelis
Copy link
Member

While unlikely in most TCA applications, it is possible for an action to enter the store when another action leaves the internal action buffer (e.g. on deinit), and sit in the buffer, unprocessed, till another action is received.

When buffered actions are processed, let's check the buffer one last time for any re-entrancy and, if it's not empty, kick off another send to process them.

@stephencelis stephencelis merged commit 5b78fbc into main Sep 8, 2022
@stephencelis stephencelis deleted the re-entrant-fix branch September 8, 2022 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants