Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid simultaneous access crash on double-cancel #137

Merged
merged 3 commits into from
May 26, 2020

Conversation

stephencelis
Copy link
Member

Fixes #136.

@@ -223,17 +223,40 @@ final class EffectCancellationTests: XCTestCase {

let expectation = self.expectation(description: "wait")
effect
.sink(receiveCompletion: { _ in expectation.fulfill() }, receiveValue: { _ in })
.sink(receiveCompletion: { _ in
print("completed")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some clean up to do here...

Copy link
Member

@mbrandonw mbrandonw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

much simpler!

@stephencelis stephencelis merged commit bf24a8c into master May 26, 2020
@stephencelis stephencelis deleted the fix-cancellation branch May 26, 2020 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SwiftUICaseStudies app crashes
2 participants