Nudge issue filers to repro in vanilla SwiftUI #1562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gently remind filers to attempt to repro issues in vanilla SwiftUI, rather than imply that such issues shouldn't be filed.
|
I agree with you. Being able to reproduce something in Vanilla SwiftUI requires a certain knowledge of both TCA and SwiftUI. This is maybe not the case of everyone that will stumble upon a legitimate bug. |
|
Thanks for bringing this up, and we agree. We also agree with @tgrapperon that we could make it a non-required checklist item. Want to do that and then we can merge? |
Yep, I'll make that change in an hour. |
|
I updated the checklist item to be non-required. |
gohanlon
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's great to remind filers to attempt to reproduce issues in vanilla SwiftUI and include those findings in their initial report. But, the new checklist item may exclude the filing of issues that TCA would want to respond to. In the past, such issues have led to good discussions on GitHub, documentation enhancements, and, I think, even additions to TCA.
Note: Despite being wordy, I used "this bug is also reproducible" rather than simply "this bug is reproducible". My intent is to clearly imply that vanilla SwiftUI issues are still welcome, rather than perhaps imply vanilla issues shouldn't be filed.
Thoughts?