Workaround for BindingAction existential layout crash #1881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephencelis
added
the
apple bug
mbrandonw
approved these changes
Jan 30, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will address the crash found in #1877. The fact that
BindingActionholds onto anAnyexistential directly means that attempting to extract another action from an enum that holds aBindingActioncan lead to crashes in release mode depending on the layout.This Swift bug is fixed in Swift 5.8, but we will need to provide a workaround.
Will start by pushing a test case to verify the crash on CI, then will push a workaround that boxes the existential in < 5.8.