Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use CaseKeyPath in UnitTest. #2637

Merged
merged 1 commit into from
Dec 11, 2023
Merged

Use CaseKeyPath in UnitTest. #2637

merged 1 commit into from
Dec 11, 2023

Conversation

yimajo
Copy link
Contributor

@yimajo yimajo commented Dec 11, 2023

Use CaseKeyPath in test code where @Reducer is used.

Copy link
Member

@stephencelis stephencelis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@stephencelis stephencelis merged commit 897cf6a into pointfreeco:main Dec 11, 2023
5 checks passed
@yimajo yimajo deleted the refactor/use_case_key_path branch December 11, 2023 23:12
cgrindel-self-hosted-renovate bot added a commit to cgrindel/rules_swift_package_manager that referenced this pull request Dec 12, 2023
…ure to from: "1.5.4" (#799)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
|
[pointfreeco/swift-composable-architecture](https://togithub.com/pointfreeco/swift-composable-architecture)
| patch | `from: "1.5.3"` -> `from: "1.5.4"` |

---

### Release Notes

<details>
<summary>pointfreeco/swift-composable-architecture
(pointfreeco/swift-composable-architecture)</summary>

###
[`v1.5.4`](https://togithub.com/pointfreeco/swift-composable-architecture/releases/tag/1.5.4)

[Compare
Source](https://togithub.com/pointfreeco/swift-composable-architecture/compare/1.5.3...1.5.4)

#### What's Changed

- Fixed: Archives should no longer fail due to `BindableAction` symbols
(thanks [@&#8203;rhysm94](https://togithub.com/rhysm94),
[pointfreeco/swift-composable-architecture#2641).
- Fixed: Stores no longer leak for the duration of an async effect.
Instead, they will automatically cancel their in-flight effects when
they deinitialize
([pointfreeco/swift-composable-architecture#2643).
- Infrastructure: Improve docs for sharing logic in parent and child
features
([pointfreeco/swift-composable-architecture#2638).
- Infrastructure: Update test cases to use case key paths (thanks
[@&#8203;yimajo](https://togithub.com/yimajo),
[pointfreeco/swift-composable-architecture#2637).
- Infrastructure: Fix tutorial code diffs
([pointfreeco/swift-composable-architecture#2642).

**Full Changelog**:
pointfreeco/swift-composable-architecture@1.5.3...1.5.4

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get
[config help](https://togithub.com/renovatebot/renovate/discussions) if
that's undesired.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMDAuMCIsInVwZGF0ZWRJblZlciI6IjM2LjEwMC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: Self-hosted Renovate Bot <361546+cgrindel-self-hosted-renovate[bot]@users.noreply.github.enterprise.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants